From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: GDI+ take 3
Date: Tue, 14 Apr 2020 22:24:08 +0300
Message-ID: <83o8rthnvr.fsf@gnu.org>
References: <86h7xzc5ai.fsf@csic.es> <83d08mt7gy.fsf@gnu.org>
 <83eesrkivc.fsf@gnu.org> <865ze3wvk8.fsf@csic.es>
 <837dyihyjc.fsf@gnu.org> <877dyh28ci.fsf@tcd.ie>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="22150"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 21:25:01 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jORB7-0005eH-1G
	for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 21:25:01 +0200
Original-Received: from localhost ([::1]:37782 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jORB6-0005Z4-4g
	for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 15:25:00 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39163)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1jORAc-00054t-Oh
 for emacs-devel@gnu.org; Tue, 14 Apr 2020 15:24:31 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48532)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1jORAb-0007ZM-Jp; Tue, 14 Apr 2020 15:24:29 -0400
Original-Received: from [176.228.60.248] (port=1503 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jORAa-0000yM-Js; Tue, 14 Apr 2020 15:24:29 -0400
In-Reply-To: <877dyh28ci.fsf@tcd.ie> (contovob@tcd.ie)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:246965
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/246965>

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: Juan José García-Ripoll
>  <juanjose.garciaripoll@gmail.com>,
>   emacs-devel@gnu.org
> Date: Tue, 14 Apr 2020 20:08:45 +0100
> 
> No testing, just a compiler warning:
> 
>   image.c:6240:1: warning: ‘image_can_use_native_api’ defined but not used [-Wunused-function]
>    6240 | image_can_use_native_api (Lisp_Object type)
>         | ^~~~~~~~~~~~~~~~~~~~~~~~

Ugh!

> Is the following okay as a fix?

No, that's not right, because it will break the WINDOWSNT build.  I
fixed it slightly differently, please take a look.

Thanks.