From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs for pure Gtk3 Date: Mon, 27 Apr 2020 18:03:54 +0300 Message-ID: <83o8rd3r8l.fsf@gnu.org> References: <20200426.165604.2054625945129238824.masm@luna.pink.masm11.me> <834kt673cy.fsf@gnu.org> <20200427.213727.386515228111850912.masm@luna.pink.masm11.me> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30978"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuuki Harano Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 27 17:05:14 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jT5Jq-0007vV-A0 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Apr 2020 17:05:14 +0200 Original-Received: from localhost ([::1]:49892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT5Jp-0004ci-AU for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Apr 2020 11:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT5If-0003kE-DQ for emacs-devel@gnu.org; Mon, 27 Apr 2020 11:04:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37290) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT5Ie-0005Av-1S; Mon, 27 Apr 2020 11:04:00 -0400 Original-Received: from [176.228.60.248] (port=3603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jT5Id-0005hr-0y; Mon, 27 Apr 2020 11:03:59 -0400 In-Reply-To: <20200427.213727.386515228111850912.masm@luna.pink.masm11.me> (message from Yuuki Harano on Mon, 27 Apr 2020 21:37:27 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247932 Archived-At: > Date: Mon, 27 Apr 2020 21:37:27 +0900 (JST) > Cc: emacs-devel@gnu.org > From: Yuuki Harano > > > . You don't seem to have a copyright assignment on file. This would > > be a significant contribution to Emacs, for which we must have > > such an assignment from you before bringing this code into the > > Emacs repository. Would you be willing to start the legal > > paperwork now? If so, I will send you the form to fill. > > Yes. Please send me it. Form sent off-list. > By the way, this fork contains much code written by @fejfighter. > He said "for now: Yes I do agree to assign my code to the FSF." here, > https://github.com/masm11/emacs/pull/11#issuecomment-600856858 . > What to do? He should fill the form I sent to you, separately, and email it according to instructions. > Because I was not going to merge to mainline when I started porting, > older commit messages are in Japanese. If you don't like Japanese > messages, I can make one big commit instead of existing commits. That's probably the best. But there's time before that happens, and you can meanwhile keep the original log messages while the code is on the branch. > Since pgtk emacs is configured with '--without-x', existing X code > is disabled. If configured with '--with-x', the existing X support > should be enabled as before. Would configuring --with-x disable Pgtk support code? That is, do the X and Pgtk support contradict each other, and cannot live in the same binary? Or maybe I don't have a clear idea what exactly gets disabled when building with Pgtk -- can you elaborate? > Pgtk emacs supports X window system too through Gtk library. > It can handle Wayland, X window system, and TTY in the same session. > But segmentation fault may occur when running on X and Wayland > in the same session. I guess those segfaults need to be fixed, because having a GUI Emacs that can only run on Wayland would be a limitation that users might be unhappy about? > Since Gtk does not support these functions on Wayland, they don't work > on Wayland. On X, they should work. > - x_set_no_focus_on_map > - x_set_no_accept_focus > - x_set_z_group > - raise/lower > - gtk_plug Someone who uses Emacs a lot on X should chime in and tell whether the lack of these features is a serious flaw or just a minor inconvenience. > Since Gtk does not support this function, it doesn't work, even if on X. > - vendor_specific_keysyms Can you give examples of these keysyms, and say something about their popularity? > I don't know about Lisp threads. I have never supported it explicitly. > Pgtk emacs may not support it. Well, for starters see if test/src/thread-tests.el runs and succeeds in your Pgtk build. > Gtk supports w32, but I have never tested on w32. This would be nice, but is much less important, IMO. The most important task is to keep users of Posix systems happy with the Pgtk build. Thanks.