From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Thu, 04 Jun 2020 17:07:21 +0300 Message-ID: <83o8pyc4bq.fsf@gnu.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> <83tuzueogo.fsf@gnu.org> <6272275C-560C-4437-90F1-2A8294D27019@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118027"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tom@tromey.com, simon@polaris64.net, 41544@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 04 16:08:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgqXQ-000UY8-Q3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 16:08:08 +0200 Original-Received: from localhost ([::1]:53516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgqXP-0007SD-RY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 10:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgqXK-0007S5-Fb for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 10:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgqXK-0004l0-5n for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 10:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgqXK-0004m4-1S for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2020 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159127966318330 (code B ref 41544); Thu, 04 Jun 2020 14:08:01 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 4 Jun 2020 14:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:47173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgqX1-0004la-8k for submit@debbugs.gnu.org; Thu, 04 Jun 2020 10:07:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgqWz-0004lN-FN for 41544@debbugs.gnu.org; Thu, 04 Jun 2020 10:07:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33343) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgqWt-0004b1-Hj; Thu, 04 Jun 2020 10:07:35 -0400 Original-Received: from [176.228.60.248] (port=2435 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jgqWs-0006uU-Ka; Thu, 04 Jun 2020 10:07:35 -0400 In-Reply-To: <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 3 Jun 2020 22:08:46 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181509 Archived-At: > From: Mattias Engdegård > Date: Wed, 3 Jun 2020 22:08:46 +0200 > Cc: Tom Tromey , Simon Pugnet , > 41544@debbugs.gnu.org > > Now about the consolidation of the contrast colour predicate (color-dark-p): as described previously in detail, the current code for doing so in various places is unsatisfactory. For example, some of the methods employed classify #00ff00 as a "dark" colour, leading to suboptimal results. (Try typing #00ff00 in css-mode.) Let's please discuss each problem in detail (I tried to understand them from the log message you posted, but couldn't find rationale there). And in any case, I will prefer solutions that fix any problems locally, not changes in low-level stuff used in many other places, because the latter run the risk of introducing new bugs. As the problems are quite minor, AFAICT, solving them in unsafe ways is something to be avoided. > There are other bugs that are annoying in themselves, but need to be fixed in order to make progress. Start Emacs in TTY mode with TERM=xterm-color and evaluate (color-name-to-rgb "blue"). Notice how one of the components is greater than 1 -- this is the unfortunate result of several bad decisions. You mean, the component that is 1.0393? What bad decisions caused that, what problems does this small deviation causes in itself? We should weigh the gravity of the problems we try to solve here with the potential of breaking working code elsewhere which relies on these idiosyncrasies. Thanks.