From: Eli Zaretskii <eliz@gnu.org>
To: mattiase@acm.org
Cc: pipcet@gmail.com, emacs-devel@gnu.org
Subject: Re: master 64e25cd: More robust NS hex colour string parsing
Date: Fri, 12 Jun 2020 22:25:14 +0300 [thread overview]
Message-ID: <83o8po3x45.fsf@gnu.org> (raw)
In-Reply-To: <83pna43xrl.fsf@gnu.org> (message from Eli Zaretskii on Fri, 12 Jun 2020 22:11:10 +0300)
> Date: Fri, 12 Jun 2020 22:11:10 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: pipcet@gmail.com, emacs-devel@gnu.org
>
> The error checking aside, are the return values of the original code
> the same as of the proposed unified code? If not, which of the 4
> current versions differ, and how?
Also, the return value in case of error seems to change the
externally-visible behavior:
> +If STRING is not in one of the above forms, return nil. */)
> + (Lisp_Object string)
> +{
> + unsigned short r, g, b;
> + return (parse_color_spec (SSDATA (string), &r, &g, &b)
> + ? list3i (r, g, b)
> + : Qnil);
> +}
At least tty-color-standard-values seems to never return nil for an
RGB spec, but now it will, right? Can its callers cope with such a
return value?
And I wonder how the other callers of parse_color_spec will behave if
it detects an error and returns false. Did you audit the code of the
callers to see if this could cause trouble?
next prev parent reply other threads:[~2020-06-12 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200608120746.30163.87810@vcs0.savannah.gnu.org>
[not found] ` <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org>
2020-06-08 12:26 ` master 64e25cd: More robust NS hex colour string parsing Pip Cet
2020-06-08 16:15 ` Mattias Engdegård
2020-06-12 16:59 ` Mattias Engdegård
2020-06-12 17:33 ` Eli Zaretskii
2020-06-12 19:00 ` Mattias Engdegård
2020-06-12 19:11 ` Eli Zaretskii
2020-06-12 19:25 ` Eli Zaretskii [this message]
2020-06-13 10:17 ` Mattias Engdegård
2020-06-13 11:59 ` Eli Zaretskii
2020-06-13 15:39 ` Mattias Engdegård
2020-06-13 15:58 ` Eli Zaretskii
2020-06-13 16:44 ` Mattias Engdegård
2020-06-13 17:09 ` Eli Zaretskii
2020-06-13 17:29 ` Mattias Engdegård
2020-06-13 17:35 ` Eli Zaretskii
2020-06-13 17:56 ` Mattias Engdegård
2020-06-13 18:40 ` Eli Zaretskii
2020-06-15 8:31 ` Mattias Engdegård
2020-06-21 7:48 ` Mattias Engdegård
2020-06-21 14:59 ` Eli Zaretskii
2020-06-21 19:23 ` Mattias Engdegård
2020-06-13 19:15 ` Basil L. Contovounesios
2020-06-12 19:15 ` Pip Cet
2020-06-13 10:40 ` Mattias Engdegård
2020-06-12 18:33 ` Basil L. Contovounesios
2020-06-13 17:52 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8po3x45.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.