From: Eli Zaretskii <eliz@gnu.org>
To: Yichao Yu <yyc1992@gmail.com>
Cc: 42673@debbugs.gnu.org
Subject: bug#42673: 26.3; Return value of XGetIMValues not checked in xim_open_dpy (src/xterm.c)
Date: Sun, 02 Aug 2020 20:23:36 +0300 [thread overview]
Message-ID: <83o8ntarmv.fsf@gnu.org> (raw)
In-Reply-To: <CAMvDr+SL=_PQ3jxj9MPMWzV43t0aw8zgYNV7VJ4KmwSBk2WUPQ@mail.gmail.com> (message from Yichao Yu on Sun, 2 Aug 2020 09:22:53 -0400)
merge 42673 42676 42677
thanks
> From: Yichao Yu <yyc1992@gmail.com>
> Date: Sun, 2 Aug 2020 09:22:53 -0400
> Cc: Yichao Yu <yyc1992@gmail.com>
>
> The call in question is at
> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/xterm.c?id=9fe2bdb88a4ebd4b2286c1c2a2a2ba7411af01b6#n10316
> Since the return value isn't checked, a failure to initialize here can
> cause `dpyinfo->xim_styles` to be `NULL` which intern cause readers
> like https://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfns.c?id=9fe2bdb88a4ebd4b2286c1c2a2a2ba7411af01b6#n2659
> to pass a `NULL` pointer to `best_xim_style` and crash.
>
> The fix is to check if the return value of `XGetIMValues` is not
> `NULL` and if it is not `NULL`, disable XIM.
Thanks, other people also reported this, so this is now fixed on the
emacs-27 branch.
prev parent reply other threads:[~2020-08-02 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 13:22 bug#42673: 26.3; Return value of XGetIMValues not checked in xim_open_dpy (src/xterm.c) Yichao Yu
2020-08-02 17:23 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8ntarmv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42673@debbugs.gnu.org \
--cc=yyc1992@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.