From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 14635@debbugs.gnu.org
Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes
Date: Fri, 30 Oct 2020 15:43:22 +0200 [thread overview]
Message-ID: <83o8kjakxx.fsf@gnu.org> (raw)
In-Reply-To: <CABczVwcWkt5L++G2aWoQAjOn97d-ZU8fw1q11+sw6qHggM0unw@mail.gmail.com> (message from Mauro Aranda on Fri, 30 Oct 2020 10:35:33 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Fri, 30 Oct 2020 10:35:33 -0300
> Cc: 14635@debbugs.gnu.org
>
> For the default face, face-spec-reset-face only sets all attributes to
> default values if (display-graphic-p frame) returns nil. So on a
> graphical display, it never resets :family, :foundry, :width, :height,
> :weight, :slant, :foreground and :background.
That's because on GUI frames there's no real default for these
attributes (unlike on a TTY where we inherit the colors of the
terminal). So we simply _cannot_ reset the attributes like that,
because there's nothing to reset to. E.g., unspecified-fg only has
meaning on a TTY frame.
> What would be the right way for face-spec-reset-face to reset all the
> attributes of the default face to the default values, in a graphic
> display?
Doesn't customizing a face record the original value in some property
of the face symbol? If so, reverting the customizations should use
those recorded values, I think.
next prev parent reply other threads:[~2020-10-30 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 9:18 bug#14635: 24.3.50; Regression in Customize: no revert changes Drew Adams
2013-06-16 10:30 ` Juanma Barranquero
2020-10-30 13:35 ` Mauro Aranda
2020-10-30 13:43 ` Eli Zaretskii [this message]
2020-10-30 14:03 ` Mauro Aranda
2020-10-30 14:16 ` Eli Zaretskii
2020-10-30 14:23 ` Mauro Aranda
2020-10-31 14:56 ` Mauro Aranda
2022-02-05 23:39 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8kjakxx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14635@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.