From: Eli Zaretskii <eliz@gnu.org>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] lisp/net/browse-url.el allow fragments in file: urls
Date: Thu, 01 Apr 2021 10:20:20 +0300 [thread overview]
Message-ID: <83o8eyh3nv.fsf@gnu.org> (raw)
In-Reply-To: <CA+G3_PN-vSetiVmtY8Ewj3Cuu1LqhVZrWNP3mFeKLDcmBp-qCQ@mail.gmail.com> (message from Tom Gillespie on Wed, 31 Mar 2021 19:16:32 -0700)
> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Wed, 31 Mar 2021 19:16:32 -0700
>
> This fixes the current behavior of browse-url--non-html-file-url-p and
> makes it possible to open file:// urls that end with a #fragment. The
> current behavior results in a nasty side effect where opening a file
> with browse-url-emacs that has a fragment causes any invocation of
> call-process to fail because the fragment is not handled correctly.
Thanks, but can you show a test case for this (or, better yet, write a
test for our test suite)?
next prev parent reply other threads:[~2021-04-01 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 2:16 [PATCH] lisp/net/browse-url.el allow fragments in file: urls Tom Gillespie
2021-04-01 7:20 ` Eli Zaretskii [this message]
2021-04-02 0:22 ` Tom Gillespie
2021-04-02 5:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8eyh3nv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.