From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47718: Fix epa-file-insert-file-contents substring error Date: Mon, 12 Apr 2021 14:57:51 +0300 Message-ID: <83o8ej3ebk.fsf@gnu.org> References: <8735vv2a39.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20657"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juntaka@protonmail.com, 47718@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 13:59:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVvDi-00053X-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 13:59:10 +0200 Original-Received: from localhost ([::1]:33170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVvDh-0006C2-0v for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 07:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVvDZ-0006AB-VM for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 07:59:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVvDZ-00020p-Nq for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 07:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVvDZ-0004t0-Mw for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 07:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2021 11:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47718 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 47718-submit@debbugs.gnu.org id=B47718.161822870018729 (code B ref 47718); Mon, 12 Apr 2021 11:59:01 +0000 Original-Received: (at 47718) by debbugs.gnu.org; 12 Apr 2021 11:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:56670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVvCu-0004s1-FL for submit@debbugs.gnu.org; Mon, 12 Apr 2021 07:58:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVvCr-0004rj-96 for 47718@debbugs.gnu.org; Mon, 12 Apr 2021 07:58:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52353) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVvCl-0001VI-H9; Mon, 12 Apr 2021 07:58:11 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVvCj-000510-6z; Mon, 12 Apr 2021 07:58:10 -0400 In-Reply-To: <8735vv2a39.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 12 Apr 2021 10:14:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203892 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 12 Apr 2021 10:14:34 +0200 > Cc: 47718@debbugs.gnu.org > > juntaka writes: > > > I think substring occurs error when TO is longer than its content. > > This patch will fix the substring bug in epa-file-insert-file-contents. > > Thanks; applied to Emacs 28. Actually, I wonder whether this is TRT: why should we silently accept invalid inputs when substring itself doesn't? IOW, can we please have a real-life use case where this happens, and where silently "fixing" this input is TRT? TIA.