From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Thu, 02 Sep 2021 18:59:24 +0300 Message-ID: <83o89bynmr.fsf@gnu.org> References: <87sfys6ubm.fsf@mail.linkov.net> <87eeacdnmg.fsf@gnus.org> <87h7f7z8ui.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5196"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50256@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 18:02:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLpAv-00016T-6h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 18:02:49 +0200 Original-Received: from localhost ([::1]:49610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLpAt-0002MF-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 12:02:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLp8F-0000cv-GT for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 12:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLp8F-0003hU-69 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 12:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLp8F-0000EH-52 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 12:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 16:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.1630598376802 (code B ref 50256); Thu, 02 Sep 2021 16:00:03 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 2 Sep 2021 15:59:36 +0000 Original-Received: from localhost ([127.0.0.1]:41829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLp7n-0000Cr-L3 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 11:59:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLp7m-0000Ce-08 for 50256@debbugs.gnu.org; Thu, 02 Sep 2021 11:59:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38320) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLp7g-0003CR-EQ; Thu, 02 Sep 2021 11:59:28 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1108 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLp7g-0002r4-1w; Thu, 02 Sep 2021 11:59:28 -0400 In-Reply-To: (message from martin rudalics on Thu, 2 Sep 2021 16:43:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213280 Archived-At: > Cc: larsi@gnus.org, juri@linkov.net, 50256@debbugs.gnu.org > From: martin rudalics > Date: Thu, 2 Sep 2021 16:43:02 +0200 > > >> >> pos_visible_p already does > >> >> > >> >> if (XBUFFER (w->contents) != current_buffer) > >> >> { > >> >> old_buffer = current_buffer; > >> >> set_buffer_internal_1 (XBUFFER (w->contents)); > >> >> } > >> > > >> > I'm asking if this is the desired behavior, when Lisp runs this inside > >> > with-current-buffer? > >> > >> It is the _necessary_ behavior when WINDOW is not the selected window > >> and its buffer is not current. > > > > But in the case in point, WINDOWS _was_ the selected window. That's > > why pos-visible-in-window-p used PT. Which is what you said was the > > bug. Or am I missing something? > > No. The above was meant in response to your earlier: > > If we want to support the current documentation to the letter, the > only way of doing that I know of is to force WINDOW to display the > current buffer, at least internally, i.e. to switch to the WINDOW's > buffer for the duration of pos-visible-in-window-p. > > I mean that we needn't do that because pos_visible_p already does it. > So I'd just propose to do the trivial (line numbers are not trunk's); Yes, but I'd prefer that we first established what is the desired behavior in this case: > (pop-to-buffer "*Messages*") > (with-current-buffer "*scratch*" > (pos-visible-in-window-p nil nil t))) IOW, what to do when WINDOW is the selected window, but the current buffer is not the buffer shown in WINDOW? Would you please humor me with an answer to my question? I'd also like to hear from Lars and Juri about this. Without the agreement about the behavior in that use case, I don't see how we can reason about the fix.