From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: tumashu@163.com, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url.
Date: Sat, 13 Nov 2021 12:26:16 +0200 [thread overview]
Message-ID: <83o86oxsfr.fsf@gnu.org> (raw)
In-Reply-To: <87h7cgo0ud.fsf@yahoo.com> (message from Po Lu on Sat, 13 Nov 2021 17:34:50 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: tumashu@163.com, larsi@gnus.org, emacs-devel@gnu.org
> Date: Sat, 13 Nov 2021 17:34:50 +0800
>
> Thanks. Here's a better docstring, but I don't want to change any of
> the code until I know precisely what it does.
>
> Canonicalize URL, with SEARCH-PREFIX if URL seems to be a search query.
>
> Try to determine if URL is an address or a query for a search engine,
> and return canonicalized URL, with SEARCH-PREFIX prepended before
> cannibalisation if it seems to be such a query. Optional argument
> LOCAL-REGEX is a regular expression that URL is matched against. If the
> match is successful, then URL is treated as an address, and not a search
> query.
I'd improve like this:
"Canonicalize incomplete URL using SEARCH-PREFIX if URL is a search query.
Canonicalization means:
- prepend a scheme (a.k.a. \"protocol\") if it's missing
- append a slash if it's missing
- if URL is a search query, prepend SEARCH-PREFIX and hexify special
characters using `url-hexify-string'
Optional arg LOCAL-REGEX, if non-nil, means don't treat URLs that
match the regex as queries even if they otherwise look like it."
Given the meaning of LOCAL-REGEX (if it is indeed described correctly
above), I'd ask why its name is _LOCAL_-REGEX, not something like
ADDRESS-REGEXP? there's nothing "local" about such an address, is
there?
Thanks.
next prev parent reply other threads:[~2021-11-13 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:36 Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url tumashu
2021-11-11 9:39 ` Po Lu
2021-11-11 10:49 ` tumashu
2021-11-11 10:53 ` Po Lu
2021-11-11 10:53 ` Lars Ingebrigtsen
2021-11-11 11:15 ` Po Lu
2021-11-11 11:58 ` Lars Ingebrigtsen
2021-11-11 12:21 ` Po Lu
2021-11-11 12:25 ` Lars Ingebrigtsen
2021-11-13 1:08 ` Po Lu
2021-11-13 7:45 ` Eli Zaretskii
2021-11-13 9:34 ` Po Lu
2021-11-13 10:26 ` Eli Zaretskii [this message]
2021-11-13 10:45 ` Po Lu
2021-11-13 13:29 ` Eli Zaretskii
2021-11-13 15:32 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o86oxsfr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.