From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 22324@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead)
Date: Thu, 02 Dec 2021 11:45:45 +0200 [thread overview]
Message-ID: <83o85zpcfq.fsf@gnu.org> (raw)
In-Reply-To: <87tufr74of.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 02 Dec 2021 10:10:40 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, 22324@debbugs.gnu.org
> Date: Thu, 02 Dec 2021 10:10:40 +0100
>
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
> > On 01/08/2016 03:26 PM, Eli Zaretskii wrote:
> >
> >> Thanks, that wasn't clear from the problem description. Normally,
> >> when someone says "the documentation doesn't describe the behavior
> >> accurately", they mean the documentation should be updated.
> >
> > Right, sorry. Poor wording on my part.
> >
> > But if you were talking about a documentation fix, changing the list
> > in `(emacs) Completion Styles' to include `partial-completion' is not
> > a good fix semantically, because the result would still contain the
> > word "only".
>
> This bug report is a bit on the vague side.
>
> It looks like `partial-completion' is documented in that node?
>
> The subject mentions "doesn't override", but is that about
> `completion-category-overrides' instead?
>
> ---
> This overrides the defaults specified in `completion-category-defaults'."
> ---
>
> And it does indeed prepend:
>
> (defun completion--category-override (category tag)
> (or (assq tag (cdr (assq category completion-category-overrides)))
> (assq tag (cdr (assq category completion-category-defaults)))))
>
> But... I think saying that that "overrides" is fine?
>
> So it's unclear what's suggested in this bug report.
I think the problem is that we don't clearly document how the list of
styles to be actually used for some CATEGORY is obtained from the
various contributions, like completion-category-defaults and
completion-category-overrides, and what is the priority of each
contribution in the resulting list of styles.
next prev parent reply other threads:[~2021-12-02 9:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 20:27 bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Dmitry Gutov
2016-01-08 12:17 ` Eli Zaretskii
2016-01-08 12:21 ` Dmitry Gutov
2016-01-08 12:26 ` Eli Zaretskii
2016-01-08 12:30 ` Dmitry Gutov
2016-01-08 15:31 ` Eli Zaretskii
2021-12-02 9:10 ` Lars Ingebrigtsen
2021-12-02 9:45 ` Eli Zaretskii [this message]
2021-12-06 1:16 ` Dmitry Gutov
2021-12-06 2:25 ` Lars Ingebrigtsen
2021-12-07 1:35 ` Dmitry Gutov
2021-12-07 20:28 ` Lars Ingebrigtsen
2021-12-07 22:46 ` Dmitry Gutov
2021-12-09 1:09 ` Lars Ingebrigtsen
2022-01-21 13:46 ` Lars Ingebrigtsen
2022-01-24 2:03 ` Dmitry Gutov
2022-01-24 9:46 ` Lars Ingebrigtsen
2022-01-25 2:27 ` Dmitry Gutov
2022-01-25 12:19 ` Lars Ingebrigtsen
2022-01-26 1:43 ` Dmitry Gutov
2022-01-26 2:31 ` Daniel Mendler
2022-01-26 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 13:49 ` Daniel Mendler
2022-01-26 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 18:59 ` Daniel Mendler
2022-01-26 22:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-26 23:32 ` Daniel Mendler
2022-01-27 6:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 2:35 ` Dmitry Gutov
2022-01-28 11:54 ` Daniel Mendler
2022-01-28 16:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 22:06 ` Dmitry Gutov
2022-01-28 23:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-29 1:57 ` Dmitry Gutov
2022-01-28 2:37 ` Dmitry Gutov
2022-01-28 16:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-28 21:23 ` Dmitry Gutov
2022-01-28 2:39 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o85zpcfq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22324@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.