From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53636: 29.0.50; face-remapping broken on master Date: Tue, 08 Feb 2022 14:29:35 +0200 Message-ID: <83o83hwngw.fsf@gnu.org> References: <87o83tib13.fsf@gnu.org> <87mtjd8485.fsf@gnus.org> <83a6fd9glm.fsf@gnu.org> <835yq19dk1.fsf@gnu.org> <87czk97yt6.fsf@gnus.org> <8335l49jwu.fsf@gnu.org> <835ypz8zbm.fsf@gnu.org> <87fsp2v0ky.fsf@gnus.org> <83leyu73i8.fsf@gnu.org> <87k0edrvxm.fsf@gnus.org> <83sft15egx.fsf@gnu.org> <871r0loxr9.fsf@gnus.org> <83mtj85tm1.fsf@gnu.org> <87wnibn48c.fsf@gnus.org> <8335kz4tgu.fsf@gnu.org> <87ee4hg7g6.fsf@gnus.org> <83y22p21na.fsf@gnu.org> <871r0haqzr.fsf@gnus.org> <8335kw1n9u.fsf@gnu.org> <87mtj34mdj.fsf@gnus.org> <837da6yb0j.fsf@gnu.org> <87k0e5vqjm.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53636@debbugs.gnu.org, tsdh@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 15:47:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHRm7-0001Sz-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 15:47:23 +0100 Original-Received: from localhost ([::1]:58446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHRm6-0007Ts-Hm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 09:47:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHPdG-0000tA-3h for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 07:30:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHPdD-0002iY-5w for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 07:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHPdC-0007zy-N5 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53636-submit@debbugs.gnu.org id=B53636.164432339330702 (code B ref 53636); Tue, 08 Feb 2022 12:30:02 +0000 Original-Received: (at 53636) by debbugs.gnu.org; 8 Feb 2022 12:29:53 +0000 Original-Received: from localhost ([127.0.0.1]:45744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHPd3-0007z8-GN for submit@debbugs.gnu.org; Tue, 08 Feb 2022 07:29:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHPd1-0007yw-V5 for 53636@debbugs.gnu.org; Tue, 08 Feb 2022 07:29:52 -0500 Original-Received: from [2001:470:142:3::e] (port=55396 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHPcw-0002fE-MX; Tue, 08 Feb 2022 07:29:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cZWaV3JXdt6P6gIaYLf/59J1WAPA6/jcLRfXfIcIusI=; b=KT2KAyqokeCa Z+7IkTWGJTcm1/G58DMHPzS9EOnWjOF4aZjE09bJ054p3CfdTGjoNgK+2lpk7eDQdmkt/AKz5havk eGoHxe3qdg3Zbfmh8Un88z68PD1Uu9CR9a7SFETd8XYeRu7D1o+/JXlhkiSPvwBAJHgVriphtQeLt DXBNz3ao4oZs2TO1w4D4Scwi7SQYMdWmnp43+0Y7BbJJihi9/Qt5qivAOJiPRI9aVgQv7SzNv98m7 YZR9RuNmVsI2ljwgqU2RtB9ZPhYgsycyRGeW1BcLR5UT2FxVoX+oR2mEj5rjNZAjRFJZUDhX7blVK glxDZgFs2wCy6XLDNNfUWw==; Original-Received: from [87.69.77.57] (port=3976 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHPcv-0007fJ-Mc; Tue, 08 Feb 2022 07:29:46 -0500 In-Reply-To: <87k0e5vqjm.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 08 Feb 2022 07:08:29 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226372 Archived-At: > From: Lars Ingebrigtsen > Cc: 53636@debbugs.gnu.org, tsdh@gnu.org > Date: Tue, 08 Feb 2022 07:08:29 +0100 > > Eli Zaretskii writes: > > > And what happens when you call make-frame from another buffer is not a > > bug? Is face-remapping-alist supposed to affect the buffer in which > > it is set on all frames or just on the single frame where > > face-remap-add-relative was called? > > I'm not sure. But the current behaviour (affecting all buffers on the > new frame) has to be a bug. > > >> The computation of the faces for the new frame. > > > > You mean init_frame_faces, which calls realize_basic_faces? Or do you > > mean some other kind of "face computation"? > > I don't know? I'm looking for the code that leads to the behaviour I > described. We need to agree on what "this behavior" is. Or at least I need to understand what you mean by that, in order to be able to provide information that could help you. So: in the scenario you've shown, do we want *scratch* to have its mode-line remapped on the new frame, or don't we? IOW, I agree that the result ideally shouldn't depend on the buffer where make-frame is called, but I need to know what is the desired behavior in order to find code which produces the undesired results.