From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases Date: Fri, 25 Feb 2022 09:09:36 +0200 Message-ID: <83o82vqv67.fsf@gnu.org> References: <1bfc8b00-0062-70b6-6492-01cf3947e55b@gmail.com> <1157b5f3-a393-1c2d-7f7d-2c01d4e7f1e3@gmail.com> <87y22038uz.fsf@gnus.org> <834k4osf07.fsf@gnu.org> <7f820c27-a58c-3b2b-3132-a57e2a25ea96@gmail.com> <83tucoqbfr.fsf@gnu.org> <87ee3s111a.fsf@gnus.org> <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54136@debbugs.gnu.org, larsi@gnus.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 25 08:10:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNUkC-0000fj-N9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 08:10:24 +0100 Original-Received: from localhost ([::1]:54618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNUkB-0005J4-Il for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 02:10:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNUjs-0005Ew-1H for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 02:10:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNUjq-0003Y3-7x for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 02:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNUjp-0001i2-SA for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 02:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Feb 2022 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54136 X-GNU-PR-Package: emacs Original-Received: via spool by 54136-submit@debbugs.gnu.org id=B54136.16457729746524 (code B ref 54136); Fri, 25 Feb 2022 07:10:01 +0000 Original-Received: (at 54136) by debbugs.gnu.org; 25 Feb 2022 07:09:34 +0000 Original-Received: from localhost ([127.0.0.1]:51126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNUjO-0001h9-AL for submit@debbugs.gnu.org; Fri, 25 Feb 2022 02:09:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNUjM-0001gv-1v for 54136@debbugs.gnu.org; Fri, 25 Feb 2022 02:09:32 -0500 Original-Received: from [2001:470:142:3::e] (port=58862 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNUjG-0003Ty-73; Fri, 25 Feb 2022 02:09:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wUnhnmKVcpaYqajZTnolL+cHWxYwJy09V11pQvqIG9s=; b=mfyNynMXiXYo 3u4I4NS4KFdI8l1b94z18nCbB/gTx76CNHNEAyr/YO5+9X1dU4Elz3RwVE7i0h0Lv/IQYHz+FU82H 7zPF1+A9U6JzYeaRZLZMtbXgC0uEfafuE6uDmPi6Gmkm3QXllZFCshkgf6a8hMIhoT1y7Pts53ec2 W3pRvvbYwTkT1Gh1SUCmaKFXBb3QjejHy6GDEN6+762Mrzvz3ZuGJBZNwKK5ArgSUzAT0/0WM9vox p2S0id50j145wNbFhhSt22ODZZGW5QzkKYvik49Ay6uB/dG5J3jApFcY9yv0fphTtFOmA5tv/jiab Jz5bASZ96bFjzUHyMK2+5w==; Original-Received: from [87.69.77.57] (port=1153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNUjB-0003n8-S6; Fri, 25 Feb 2022 02:09:25 -0500 In-Reply-To: <4741f5c9-8846-9584-318e-1a7536d43e70@gmail.com> (message from Jim Porter on Thu, 24 Feb 2022 17:04:42 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227617 Archived-At: > Cc: 54136@debbugs.gnu.org > From: Jim Porter > Date: Thu, 24 Feb 2022 17:04:42 -0800 > > On 2/24/2022 12:07 PM, Lars Ingebrigtsen wrote: > > Eli Zaretskii writes: > > > >> OK, so I installed my changes. > > > > The test now fails on Debian: > > > > Test esh-proc-test/kill-pipeline condition: > > (ert-test-failed > > ((should > > (equal > > (buffer-substring-no-properties output-start ...) > > (or "interrupt\n" "killed\n"))) > > :form > > (equal "killed\n" "interrupt\n") > > :value nil :explanation > > (arrays-of-different-length 7 10 "killed\n" "interrupt\n" first-mismatch-at 0))) > > FAILED 2/4 esh-proc-test/kill-pipeline (0.109668 sec) at lisp/eshell/esh-proc-tests.el:47 > > passed 3/4 esh-proc-test/kill-pipeline-head (0.112142 sec) > > passed 4/4 esh-proc-test/sigpipe-exits-process (1.010359 sec) > > > > Ran 4 tests, 3 results as expected, 1 unexpected (2022-02-24 21:06:48+0100, 1.446135 sec) > > > > 1 unexpected results: > > FAILED esh-proc-test/kill-pipeline > > Here's a patch for that. It works for me on GNU/Linux, and hopefully > it's ok on MS Windows too. Thanks, and sorry for the thinko. (I thought posting the patch would have that caught, but I guess no one reads my patches seriously.)