From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f8bb6cca33: Return the same file from locate-file in nativecomp and non Date: Sun, 13 Mar 2022 18:59:13 +0200 Message-ID: <83o829lrfi.fsf@gnu.org> References: <164712074096.14747.18124931770043811100@vcs2.savannah.gnu.org> <20220312213221.451B3C01684@vcs2.savannah.gnu.org> <87fsnmyh4q.fsf@gnus.org> <87y21eviwn.fsf@gnus.org> <831qz6mlw0.fsf@gnu.org> <87bkyauecx.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28953"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 13 18:00:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTRa1-0007Or-Qa for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Mar 2022 18:00:30 +0100 Original-Received: from localhost ([::1]:51652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTRa0-0008Dk-VY for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Mar 2022 13:00:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTRZ4-0007ZB-Ce for emacs-devel@gnu.org; Sun, 13 Mar 2022 12:59:30 -0400 Original-Received: from [2001:470:142:3::e] (port=57840 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTRZ4-0007ee-14; Sun, 13 Mar 2022 12:59:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c8Ipi3di58hFadSiY5iqnnVxis52lCSu7jTL/NLjIWY=; b=Vue8L7pHhw8U KtPb2oyvnWl37m2+fKS0ULDGKmTapjTsebcXbWIEl3I33viAkZQbBJyE9Ual7JSwG5o4rGCbe7poo 9mCLUIYi6FftlIZTF2vKqir9UeIvB6bLxsPpyKyByAkgMv97PnwATauXv+noNiccENL5zZHwh077H kvyfkRBuwXSxuN2pyBMWGnrvdl/387Xarwbc1pFOVi8RUM7wftGFXNyWCW1MkenqJk4O4uoF67HHT A4alvgJ+WksIN2JbL2F6IEdSMQnu8uu7QH+jsC/ITy9+TJXjprvJSZRIN/tNcZv1WfrIosMi0HtTm ktzGI4lOuV1WBnAm8x+zkg==; Original-Received: from [87.69.77.57] (port=2942 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTRZ3-0000vy-6V; Sun, 13 Mar 2022 12:59:29 -0400 In-Reply-To: <87bkyauecx.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Mar 2022 15:16:46 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287074 Archived-At: > From: Lars Ingebrigtsen > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Sun, 13 Mar 2022 15:16:46 +0100 > > Eli Zaretskii writes: > > > I object to such backward-incompatible change in a public API. Please > > revert that change. > > Stefan's patch does not change the behaviour of locate-file (after my > patch). It does change the behaviour of locate-file-internal, but > that's not a public function (and it's only used in locate-file). So > I'm not sure what you mean here. I mean locate-file-internal. It behaved like that since the merge of native-compilation, which happened more than a year ago. Emacs 28 will be released very soon with that behavior, which means that behavior will be out there until Emacs 29.1 is released, at least two years from now? And all that just because some test failed? Sorry, I cannot agree to that. It is very easy, albeit less elegant, to add a new optional argument; then we can have the cake and eat it, too (provided that this solution is at all correct and doesn't cause regressions, which I'm not sure is true). More generally, I'm not at all convinced that the problem, as presented in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51308#14, indeed needs a solution that makes locate-file behave the same as it did in Emacs 27, because the *.eln files introduce new aspects into the stuff that 'load' and 'load-history' intend to support. We didn't discuss this enough, and I'm not even sure we have a common POV on this. Bottom line: this needs further discussion.