From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Support fullscreen values fullheight and fullwidth on pgtk Date: Fri, 08 Jul 2022 08:49:15 +0300 Message-ID: <83o7y040is.fsf@gnu.org> References: <87r1477ggj.fsf@yahoo.com> <87sfom5f64.fsf@yahoo.com> <8735gl446y.fsf@yahoo.com> <763362fd85bae99fd8772ca219a7c3561200fb40.camel@florommel.de> <87czfn2a2r.fsf@yahoo.com> <83y1ybacpl.fsf@gnu.org> <789eeae59ff5b6b8ea6a86f2363aa87b4850fa17.camel@florommel.de> <221b39fb759fed7ca2b32b20c4fcab8508fb805b.camel@florommel.de> <87k08uv33z.fsf@yahoo.com> <87sfnhty8v.fsf@yahoo.com> <875yk85oav.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29059"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@florommel.de, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 08 07:50:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9gt7-0007Pu-Mn for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 07:50:49 +0200 Original-Received: from localhost ([::1]:50534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9gt6-0005R0-AL for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 01:50:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9grg-0003oy-NM for emacs-devel@gnu.org; Fri, 08 Jul 2022 01:49:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9grf-0003le-Ad; Fri, 08 Jul 2022 01:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ckXouDu2YnCfNSiW0bZmP2prgO4AboBGjIwBgRb2LXk=; b=VQKhk/fr+9Tt /mm9cXj9PKHZ5T6LYCC2qoo7SxkbWqFOjCFJBrF7nQY8X/OqijsNG8OxsZ/jWrA9UgfHJGa1MJX8N MknkNcp0CSbLHBOYIrvlOpc6ONw65GXo2g/G4KvjLuCPRj22585x4bJ/xbQMiKKwlX+SHFNw4G/Sa BE5xAMgadHG3XNx3XeXpXJQd3PTe1DyvyIpciB+uti8xw8L4C1stGr4k1LHYydHuwgpmWR/2FCNC4 Bqop1oREVxoH6pS1TVQRb6ivf8pzQwTj+XsAjdOKwMFXpk66M/qqBv/kkSx+jEm4Mm7zv+yqQ8g6P YGterOM6vyiauJnLbhDrRQ==; Original-Received: from [87.69.77.57] (port=4444 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9grd-0002kQ-Jn; Fri, 08 Jul 2022 01:49:18 -0400 In-Reply-To: <875yk85oav.fsf@yahoo.com> (message from Po Lu on Fri, 08 Jul 2022 10:30:16 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291942 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Fri, 08 Jul 2022 10:30:16 +0800 > > Actually, I think we need a more general mechanism to report which > `fullscreen' states can be set, and then to use that in > `toggle-frame-fullscreen' (and other places that set the > `fullscreen-restore' frame parameter.) > > So this: > > (if (memq fullscreen-restore '(maximized fullheight fullwidth)) > > would probably become > > (if (display-supports-fullscreen-p fullscreen-restore) > > WDYT? If this is useful and makes the code clearer and easier to maintain, sure. But the display-*-p predicates need to be implemented for all the supported frame types, not just for PGTK and X.