From: Eli Zaretskii <eliz@gnu.org>
To: Laurence Warne <laurencewarne@gmail.com>
Cc: 59307@debbugs.gnu.org
Subject: bug#59307: [PATCH] Cancel proced auto update timer if no proced buffers are open
Date: Sun, 20 Nov 2022 12:35:45 +0200 [thread overview]
Message-ID: <83o7t16hha.fsf@gnu.org> (raw)
In-Reply-To: <CAE2oLqh2r5gw77aWfP=hWTaVzcHTHtbyRGx--bcEt4L406xb+Q@mail.gmail.com> (message from Laurence Warne on Wed, 16 Nov 2022 11:57:09 +0000)
> From: Laurence Warne <laurencewarne@gmail.com>
> Date: Wed, 16 Nov 2022 11:57:09 +0000
>
> Hi, this patch cancels the proced auto update timer if it's detected that no proced buffers are open.
Thanks, but the patch seems to be incomplete: it indeed cancels the timer
when no buffer uses it, but it doesn't update the display when some buffer
_does_ use the timer. So the effect of this patch is that invoking
proced-toggle-auto-update to turn on the auto-update has no effect: the
buffer is not updated as expected.
To reproduce, apply the patch and then type
M-x proced-toggle-auto-update RET
The result is that the Proced display is not updated every 5 sec as
expected, and the value of proced-auto-update-timer is nil.
Did you post the right patch, and if so, how was it tested?
next prev parent reply other threads:[~2022-11-20 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 11:57 bug#59307: [PATCH] Cancel proced auto update timer if no proced buffers are open Laurence Warne
2022-11-20 10:35 ` Eli Zaretskii [this message]
2022-11-20 11:18 ` Laurence Warne
2022-11-20 11:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7t16hha.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59307@debbugs.gnu.org \
--cc=laurencewarne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.