From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Thu, 24 Nov 2022 13:19:41 +0200 Message-ID: <83o7swwqeq.fsf@gnu.org> References: <66176.1668992898@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721-done@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 12:20:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyAHR-00011t-H1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 12:20:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyAH1-0003Sf-NI; Thu, 24 Nov 2022 06:20:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAGy-0003SK-3Y for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:20:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyAGw-0004Wv-Be for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyAGw-0007hA-0m for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:20:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58721 X-GNU-PR-Package: emacs Mail-Followup-To: 58721@debbugs.gnu.org, eliz@gnu.org, gusbrs.2016@gmail.com Original-Received: via spool by 58721-done@debbugs.gnu.org id=D58721.166928877129532 (code D ref 58721); Thu, 24 Nov 2022 11:20:01 +0000 Original-Received: (at 58721-done) by debbugs.gnu.org; 24 Nov 2022 11:19:31 +0000 Original-Received: from localhost ([127.0.0.1]:57513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAGR-0007gG-6S for submit@debbugs.gnu.org; Thu, 24 Nov 2022 06:19:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAGP-0007g4-Ge for 58721-done@debbugs.gnu.org; Thu, 24 Nov 2022 06:19:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAGJ-0004R0-UA; Thu, 24 Nov 2022 06:19:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kPMMJaJSgFCdObMd+uBJIb76hkUMpcu9XJ9/g3p+Ezg=; b=qJs3BK0/jN5F O68phth7kswOkx+vPFb71WqCs6okTfdd7OK5haaJwxpq+Yu2pUUZgAgDuLRHBkar63gDdYCsSAaMs OvCOv3h8QrlZ3nS8pWcLOm093Eegizw//rTYdHmIGmuWBhv7of47uBf/dbc58W1U1swnRRQ0NPfno kF5KoLuCFp5PG7ojCcjN/dKVIG/LvIdYxUVCS63fsBaanb4kCgj1yTPINeyeMao1xV7Jgn/5YRaOQ GJcYBYtlaMvkhZIb6q76nPdkEuye6ARQGlCbLWKEh+lDSWjpSWjuFlGH1jX4XSoWF5GRVIHHDlmEt wf0/EQ+dGsSz3sTD0KSC0Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAGJ-0000X3-7x; Thu, 24 Nov 2022 06:19:23 -0500 In-Reply-To: <66176.1668992898@alto> (message from Mike Kupfer on Sun, 20 Nov 2022 17:08:18 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248855 Archived-At: > From: Mike Kupfer > cc: 58721@debbugs.gnu.org > Date: Sun, 20 Nov 2022 17:08:18 -0800 > > > I'm not sure either, but my instincts are the same as yours. If that's > > any reference, I just tested here, and that's what "gio trash" does > > (moves the symlink, not the target). > > Yes, I tried a few graphical file browsers (Thunar, Caja, and Dolphin), > and they all move the symlink, not the target, to Trash. > > After getting my test setup straightened out, I think I have a fix for > the symlink issue and for the issue that Gustavo originally reported > (cross-filesystem trashing fails when there's already a directory with > the same name in Trash). > > I've committed these fixes separately; see attached. Gustavo, can you > try these out and make sure they handle your use case(s)? > > > > I'm okay with filing another bug report about rename-file, and > > > discussing this there. But that's a separate issue, and fix of this > > > bug should not depend on that. > > > > Understood. > > Okay. I'm not planning to follow up on this, Gustavo, so if you'd like > to lobby for a change to rename-file, you'll need to open a bug for it > (if you haven't already). No further comments, so I've now installed these changes, and I'm closing the bug. Thanks.