From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Sun, 27 Nov 2022 16:15:38 +0200 Message-ID: <83o7sspjp1.fsf@gnu.org> References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> <83fse7ut10.fsf@gnu.org> <83y1rxsvf6.fsf@gnu.org> <83r0xpssto.fsf@gnu.org> <83h6ylsrcb.fsf@gnu.org> <835yf1skse.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544@debbugs.gnu.org, stefankangas@gmail.com To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 15:16:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozISF-0000yj-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 15:16:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozIRz-0005o3-H2; Sun, 27 Nov 2022 09:16:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozIRv-0005nk-2B for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 09:16:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozIRu-0003Eq-QC for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 09:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozIRu-0005BT-JE for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 09:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.166955852719899 (code B ref 59544); Sun, 27 Nov 2022 14:16:02 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 27 Nov 2022 14:15:27 +0000 Original-Received: from localhost ([127.0.0.1]:42337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozIRK-0005At-LZ for submit@debbugs.gnu.org; Sun, 27 Nov 2022 09:15:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozIRI-0005An-RB for 59544@debbugs.gnu.org; Sun, 27 Nov 2022 09:15:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozIRB-0002wB-H0; Sun, 27 Nov 2022 09:15:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cwxwUHLLHH+jH+tBgohYv6yDBWuVMxxmWtNqUL+pWao=; b=NnTylHcyz+otRma2TDTP rz65LAgf/faq6VLA6FICv/6DsZ8hSFoI4/OUOmm1sJGz/j9sct+nREQZZEsK+JlnZXgTexzytHhJ6 vsr1grEDx9OnflR6YxVzr6CEys39RdWucxmi+yD4nUzGb7/Nz++tpB3lm+LfkmtNaEPRDJ1H0I7Yp 1TRggEOIebWi+8pn2d8KMiHvXjcp+9aO0q8r9hFhzLHzBfHAWIlx3CHE06muzrNFkl2GPIDJApxsE 2whHithsZFQZ5wDkEmnVEX0QMMhOWSOdYhbAIzJGTly0fjLmiWlnzvyUHuVRt0IvQPlT6+Wtl27oX OfzctzVBzZebHA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozIR6-0005sR-DW; Sun, 27 Nov 2022 09:15:17 -0500 In-Reply-To: (message from lux on Sun, 27 Nov 2022 14:35:01 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249220 Archived-At: > Date: Sun, 27 Nov 2022 14:35:01 +0800 > Cc: stefankangas@gmail.com, 59544@debbugs.gnu.org > From: lux > > The `rename` function, if trying to rename a file across filesystem or > device, it's not work, and give the EXDEV erorr: > >     Invalid cross-device link > > So, I add a new function `do_move_file`: if the rename fails, copy a new > file, and unlink source file. Thanks, I installed this. But something is wrong with the 2 new tests: they fail. I replaced the "good" files with the ones I get on my system, but the test fails on another system. Could you please look into the test failures and find a fix?