From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Fri, 09 Dec 2022 16:52:26 +0200 Message-ID: <83o7sczl1x.fsf@gnu.org> References: <83v8mkzrvj.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38913"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 15:53:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3eke-0009x5-Sc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 15:53:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3ekW-0004Cb-Bu; Fri, 09 Dec 2022 09:53:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ekK-0004BI-5P for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:53:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3ekI-0006M6-PD for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3ekI-0005Q1-DL for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59920-submit@debbugs.gnu.org id=B59920.167059756220823 (code B ref 59920); Fri, 09 Dec 2022 14:53:02 +0000 Original-Received: (at 59920) by debbugs.gnu.org; 9 Dec 2022 14:52:42 +0000 Original-Received: from localhost ([127.0.0.1]:36531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ejx-0005Pn-QG for submit@debbugs.gnu.org; Fri, 09 Dec 2022 09:52:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ejv-0005Pe-9N for 59920@debbugs.gnu.org; Fri, 09 Dec 2022 09:52:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ejp-0005OL-Rs; Fri, 09 Dec 2022 09:52:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rNjR4rlEW6tnnLuvcG7er2rKjQZOKr5CF1RO3B7/LcY=; b=h9yyXJIIoC1c iVIZv+TmazQqfggkNjUwU13t0xDhaetGLT6b/QnEqA4vKioHkhqy29zpayv20eFcgnJ4Luz6VDKEC 4uuz1UFxftlweSlgA8iF/BlBJJkA46xwo+cQJxISH+g7hyX2Pvttv4POneEEXoBwLvhNIir/rdRz4 NOjHeoILlCwf6yAMNkGycAoIrAeK8tFtI33xE3J5ZYuu9pNzW5KkaVPcRH/Vt34W7HWxn7466OcRX 85iGA61yice7Q1Eo4lxrbqFFzWY0OcieEzMRUWOv7FN8MY8ZHLq2z66JxjqgpFeOvzgUQIHZk3Ver kXz3jrYQxKDcGmz41N+yYw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ejp-000636-6C; Fri, 09 Dec 2022 09:52:33 -0500 In-Reply-To: (message from Stefan Kangas on Fri, 9 Dec 2022 04:42:00 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250402 Archived-At: > From: Stefan Kangas > Date: Fri, 9 Dec 2022 04:42:00 -0800 > Cc: 59920@debbugs.gnu.org > > Eli Zaretskii writes: > > > Thanks, but I think this should be optional behavior. checkdoc is not > > only used by us. > > The idea here is to encourage others to upgrade to lexical-binding, as > we are already done (at least in emacs.git, if not yet in GNU ELPA). > > I'm actually more concerned that this check will not reach enough users. > So while I think an option is a good idea, the best default is IMO to > have it enabled. I said nothing about defaults. I just think we should allow turning off this warning.