From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Date: Thu, 19 Jan 2023 21:41:34 +0200 Message-ID: <83o7qunwgh.fsf@gnu.org> References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11988"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60942@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 20:42:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIann-0002sH-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 20:42:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIanT-0006lx-Q2; Thu, 19 Jan 2023 14:42:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIanS-0006lZ-DW for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 14:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIanS-000541-5c for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 14:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIanS-0006hZ-0b for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 14:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60942 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60942-submit@debbugs.gnu.org id=B60942.167415731025739 (code B ref 60942); Thu, 19 Jan 2023 19:42:01 +0000 Original-Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 19:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:44788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIanF-0006h5-Q7 for submit@debbugs.gnu.org; Thu, 19 Jan 2023 14:41:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIanD-0006go-46 for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 14:41:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIan7-0004vY-Rm; Thu, 19 Jan 2023 14:41:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EV3rBW8xHYXaph4qaU3Avf8TEs6kHNKs3127aL9rOoA=; b=CVuGfbzap7YT5OvtQJte sEzXSaVp17Un5h1KcVHZ9iqIC8GzVDyfU91EMtaKbJdAoijgHWGldZy+YdGG4nB2udthT8VqxNhni Me5cLt+oDKJjb5yuTWcKwLNqgEzQMK3w+VYTCpiJKAHuUdrJfqlbfdlOoDKL5zKT8kyI+ArYXk3uA kTJfq8WCkZsGDyo6rON77mUdu/8nAOkyfO7Y8D5FKhvimWsfcAXALoHi/lhbetVQkju2H4D/U8w/P 9Nvkp8jHerW4jWIjEhOF+/Sqj/9LC4sDcvAhXwHtvttMQm4hIHkf2wCvOTrYf2k4FIOWgqmLgG5zB IrQOZKiR/FQlkQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIan3-0004BP-8M; Thu, 19 Jan 2023 14:41:38 -0500 In-Reply-To: (message from Jim Porter on Thu, 19 Jan 2023 11:31:24 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253728 Archived-At: > Date: Thu, 19 Jan 2023 11:31:24 -0800 > From: Jim Porter > Cc: 60942@debbugs.gnu.org > > On 1/18/2023 11:37 PM, Jim Porter wrote: > > On 1/18/2023 10:49 PM, Eli Zaretskii wrote: > >> Why do you remove a non-internal function?  We cannot possibly do that > >> if this is going to be installed on the emacs-29 branch.  But even if > >> you are going to install on master, why not leave that function alone? > >> Some code somewhere could be using it, and we don't usually remove > >> functions before a period of deprecation. > > > > I can keep 'eshell-eval-indices' around and mark it obsolete if you > > prefer; it wouldn't hurt anything. > > Here's a patch that does this. It doesn't try to fix > 'eshell-eval-indices', since people shouldn't use that anyway. (I also > renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.) Is this for master? If so, okay. Otherwise, you'll need to adjust the version in the obsolescence declaration. Thanks.