all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60942@debbugs.gnu.org
Subject: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands
Date: Thu, 19 Jan 2023 21:41:34 +0200	[thread overview]
Message-ID: <83o7qunwgh.fsf@gnu.org> (raw)
In-Reply-To: <c15efd71-1d2b-6ae9-486f-030a00271726@gmail.com> (message from Jim Porter on Thu, 19 Jan 2023 11:31:24 -0800)

> Date: Thu, 19 Jan 2023 11:31:24 -0800
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 60942@debbugs.gnu.org
> 
> On 1/18/2023 11:37 PM, Jim Porter wrote:
> > On 1/18/2023 10:49 PM, Eli Zaretskii wrote:
> >> Why do you remove a non-internal function?  We cannot possibly do that
> >> if this is going to be installed on the emacs-29 branch.  But even if
> >> you are going to install on master, why not leave that function alone?
> >> Some code somewhere could be using it, and we don't usually remove
> >> functions before a period of deprecation.
> > 
> > I can keep 'eshell-eval-indices' around and mark it obsolete if you 
> > prefer; it wouldn't hurt anything.
> 
> Here's a patch that does this. It doesn't try to fix 
> 'eshell-eval-indices', since people shouldn't use that anyway. (I also 
> renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.)

Is this for master?  If so, okay.  Otherwise, you'll need to adjust
the version in the obsolescence declaration.

Thanks.





  reply	other threads:[~2023-01-19 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19  3:36 bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Jim Porter
2023-01-19  6:49 ` Eli Zaretskii
2023-01-19  7:37   ` Jim Porter
2023-01-19 19:31     ` Jim Porter
2023-01-19 19:41       ` Eli Zaretskii [this message]
2023-01-19 20:20         ` Jim Porter
2023-01-20  1:54           ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o7qunwgh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60942@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.