From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Regression in dump-emacs-portable Date: Thu, 16 Feb 2023 17:46:41 +0200 Message-ID: <83o7pt395q.fsf@gnu.org> References: <83ttzocomk.fsf@gnu.org> <834jrncd6a.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 16:47:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSgTe-0005bS-TK for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 16:47:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSgT9-00072y-1r; Thu, 16 Feb 2023 10:46:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSgT6-00072m-SL for emacs-devel@gnu.org; Thu, 16 Feb 2023 10:46:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSgT6-0008CI-Gx; Thu, 16 Feb 2023 10:46:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=R0qI0yWNgJyNtr4pPaLaCIfFNFQH411TjOPf4IM2x/g=; b=HjDkiwKdWpgC u8hIBw50Y/rtJkUnAeUaVRGjD59KSifMWyx1cNLHIEAszF+NBwOpJPQuXvunZiqn/qIrYxhJ4Nt2T 8CV4YVpxQsZwppS+zkN4JE/6k8RgJoYV4dqkg/zVbKz3z4a+KqYsjcIw93BRZh3R8hR7kQuD+VA8a ZRrzHb5rmM0jz2b8J9qwynTOQBaDYuBDlMKlLwRhZkde7iUgOTe20KMq08Ganqit4RTQvOQl5nXpa HZlNy2VpI6VaBUB6ieAFDtVtlL+lx9R6AZVWh5KEVK3U4BzGqSgOn28VyagLKo/CMXemAyyqPY+C9 o9Puu0MHxaIjYYAA5atm/A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSgT6-000538-0G; Thu, 16 Feb 2023 10:46:44 -0500 In-Reply-To: (message from Lynn Winebarger on Thu, 16 Feb 2023 04:31:10 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303425 Archived-At: > From: Lynn Winebarger > Date: Thu, 16 Feb 2023 04:31:10 -0500 > Cc: emacs-devel > > > Almost every library in 28.2 could be redumped, excepting those which > > simply failed to load for whatever reason. > > Don't we have Lisp objects that cannot be dumped? If we do, then not > every library could be dumped even in principle. > > In 28.2, using dump-emacs-portable, the answer is, not many in the libraries in included in the Emacs > source distribution. I excluded the term and obsolete subdirectories from generating the set of libraries to > dump (but not from the final set determined from load-history). Is exclusion really the way to go, if we want eventually to support re-dumping at any given moment? > Another potential issue with this is (assuming you suggest to actually > try dumping every library) that it will take too long, and thus will > be likely to be skipped in any "normal" run of the test suite, thus > missing the point. > > My 2017-vintage laptop dumps the 1252 files, including all of leim, in 34 seconds, for a 135MB dump file. > When I added leim to the exclusions list, 1172 libraries are dumped in 24 seconds for a 83MB dump file, > which explains why my effort with 30.0.50 produces a 75MB dump. That's a lot. And I presume your build is optimized? So an unoptimized build will be slower. Running such slow tests routinely is a PITA, so such a test will probably moved to a category that doesn't run by default. > Aside from testing on a per-commit basis, isn't there a > more comprehensive set of regression tests run pre-release? Does emacs have a CI process regularly > running the test suite, or is it more ad hoc? There's EMBA.