From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Make window-list return windows for all frames Date: Sat, 17 Jun 2023 11:39:35 +0300 Message-ID: <83o7leqy7s.fsf@gnu.org> References: <83fs6sub2k.fsf@gnu.org> <83cz1wu4vw.fsf@gnu.org> <321af4c6c101bd5a1bd2@heytings.org> <83y1kjsnjh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35241"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arthur.miller@live.com, gregory@heytings.org, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 17 10:40:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qARTv-00091c-Jl for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Jun 2023 10:40:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qART9-0004a5-5J; Sat, 17 Jun 2023 04:39:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qART8-0004Zx-7e for emacs-devel@gnu.org; Sat, 17 Jun 2023 04:39:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qART6-0001ss-Su; Sat, 17 Jun 2023 04:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/43UC190swDWQCuBO+WCwSs52YZNzpx3v6QJ0PwhAPM=; b=LIIEB6l3s+GA H7kEXYJ3GAi9Y5arXnpbX5kA2T/VhurDadgTTnuetVhWkqNCPK7GqWG53I+70O7w4G4kioqXXcLGu r3VNOWyIzqgE5So3lswB7mmxk4W1aDTMByQMQieNI0MM68ahvkIonKSuvLe2TPBk6A0EuYfoarVO3 uY8EAkhue/wkmLXrF/gKuEpbKzHudV/molyjJ08AaFzF8hOpy9WFR5cngdTTf4Ey4+G/YAMOted/v ifw7Z418ez6XpZdawhAYYSCif58VDh6QJCuw/57MU9Yb6ISUItFniK1QcBpue18dVZE+WVjR0eXZF FnP/JIQbGm30QTg4GkqE6A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qART6-0004ml-DM; Sat, 17 Jun 2023 04:39:36 -0400 In-Reply-To: (message from martin rudalics on Fri, 16 Jun 2023 16:21:54 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306869 Archived-At: > Date: Fri, 16 Jun 2023 16:21:54 +0200 > Cc: gregory@heytings.org, emacs-devel@gnu.org > From: martin rudalics > > >> Yes, window-list and window-list-1 becaomes the same, just with arguments in > >> different order. Could even remove c version of window-list, and implement it as > >> a call to window-list-1. Less code, less maintanance. > > > > Martin, are there any reason we'd not want window-list to accept t as > > the FRAME argument? > > None on my side. The current implementation of 'window-list' simply > throws an error for (window-list t). Back then I made 'window-list-1' a > separate function because with > > (defvar frame-1 (selected-frame)) > (defvar window-2 (frame-root-window (make-frame))) > > calling > > (window-list frame-1 nil window-2) > > complains while > > (window-list-1 window-2 nil frame-1) > > doesn't. People were picky about such issues in the past. Thanks. then I guess we can install (on master) the patch which makes window-list accept t as the FRAME argument.