From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon Date: Fri, 28 Jul 2023 14:07:19 +0300 Message-ID: <83o7jwjnvc.fsf@gnu.org> References: <877cqpsnct.fsf@trop.in> <20230727080325.4372-1-andrew@trop.in> <87wmyl1sn8.fsf@gmx.de> <831qgtmsnf.fsf@gnu.org> <875y65jt8o.fsf@gmx.de> <87bkfwr4mg.fsf@trop.in> <87mszglcqd.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10673"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andrew@trop.in, emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 28 14:25:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPMXe-0002a0-4J for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jul 2023 14:25:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPLIm-0008Hm-Dt; Fri, 28 Jul 2023 07:06:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPLIk-0008Gw-5H for emacs-devel@gnu.org; Fri, 28 Jul 2023 07:06:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPLIj-0003QU-LV; Fri, 28 Jul 2023 07:06:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=85r7jXKpEoZNtpGGpp9JWqS7yhLQAX8FXmkKeveJ/Bk=; b=Bvx99ltI+0B3 MGxWk+yq27SS3yNHHBqEQreTu57kfxx2fOqeVOSHAyD50a8JfebUo8x063e63BofUHtIMwzelBkcS 5huLqzNdu+2EroItS2Q1qYSCiDxT3UAs44Xr1YPDuLZ3UoQzVYHNw+Gjv2ruRMBkKCSYgzcwbiMBy 3WbyuegOc45xKGwofgr09Jg1D39zATRtWf8IZIkQdbvOTuu5mcDU0b+UuEZhPIdv305rCeN2GYWPl 252s0tvCMS2fClTHLgbitEr63N1g0oWLzCvI840hajJbz4qAgPCAZfpvIx0wfh2mS0xdp5rL/+ABg KzHZC3RduF3haC/xskAkCw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPLIg-0000CO-Ee; Fri, 28 Jul 2023 07:06:29 -0400 In-Reply-To: <87mszglcqd.fsf@gmx.de> (message from Michael Albinus on Fri, 28 Jul 2023 09:24:58 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308189 Archived-At: > From: Michael Albinus > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Fri, 28 Jul 2023 09:24:58 +0200 > > Andrew Tropin writes: > > >> Done as commit 42a911c61e67caa807750cd40887b729f09aaf52. > > > > Thank you! > > You're welcome. > > I've digged the documentation further, and it seems like we've overlooked, > that XDG icon names are possible already, via the :image-path argument: > > (notifications-notify :title "I am playing music" :image-path "multimedia-player") > > So the patch wasn't necessary. I'm a little bit undecided, whether we > shall revert it. Eli? If you are unhappy with leaving it, I don't object to reverting. But if it currently causes no harm, perhaps leave it for now, and let's see if it's useful for some use cases.