From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii <eliz@gnu.org> Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 25 Nov 2023 12:23:18 +0200 Message-ID: <83o7ficesp.fsf@gnu.org> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org> <87sf50s1gh.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Thierry Volpiatto <thievol@posteo.net> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 11:24:10 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1r6ppZ-0002ZA-BZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 11:24:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1r6ppO-0003lj-JX; Sat, 25 Nov 2023 05:23:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6ppN-0003la-FR for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:23:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6ppN-0000RN-7M for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:23:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6ppR-0005NK-PT for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 05:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii <eliz@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 10:24:01 +0000 Resent-Message-ID: <handler.66394.B66394.170090782620626@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170090782620626 (code B ref 66394); Sat, 25 Nov 2023 10:24:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 25 Nov 2023 10:23:46 +0000 Original-Received: from localhost ([127.0.0.1]:37911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1r6pp2-0005MI-1S for submit@debbugs.gnu.org; Sat, 25 Nov 2023 05:23:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@gnu.org>) id 1r6poz-0005M4-VX for 66394@debbugs.gnu.org; Sat, 25 Nov 2023 05:23:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1r6pon-0000E3-Ua; Sat, 25 Nov 2023 05:23:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JwXxKoSwKGV49qe4ud7h8215rpr9r9qlaTHfggyX8AA=; b=I0bW3RF+kUnr ozw/rXmwNMwqVqUsJwD5iIOgcYSvxHQUQoshBgJFyiQupVylr9HtChrU19G3bBA3drjIvB/dfcFer HkCBzbxuLsT4Fc+CTEW6ub/pwz2DSlbv6ZAL/sYhBWNemvHIrYu3TpJV8WQj4mA/7FVeZdPw9IzVX 9+7ne33dPj5dSV782CDXiUy85zpKfb+jwD+NDWp2O9HJccVCuW64dcKwpfPAmqPDE+tlBY39vtQBf ZihamfwIBBzWs8MYHZ31r6ZrDhAa24dXcl39qfJ742tjyZ+MEyBJGmodKgyRf7Y+9BMQWW+EMzU3M YZDiXQG/dyoXa3QsiaRqAg==; In-Reply-To: <87sf50s1gh.fsf@posteo.net> (message from Thierry Volpiatto on Mon, 20 Nov 2023 18:51:10 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274948 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/274948> > Cc: Michael Heerdegen <michael_heerdegen@web.de>, stefankangas@gmail.com, > 66394@debbugs.gnu.org > From: Thierry Volpiatto <thievol@posteo.net> > Date: Mon, 20 Nov 2023 18:51:10 +0000 > > Stefan Monnier <monnier@iro.umontreal.ca> writes: > > >> Ccing also Stefan monnier because for some reasons the patch when > >> applied doesn't compile (when compiling Emacs) unless we add on > >> top: > >> > >> (cl--generic-prefill-dispatchers 0 (eql 'x) integer) > >> > >> following the advice of the compiler, > > > > Indeed, this is needed because `register.el` is preloaded and method > > dispatcher are generated&compiled "on the fly" but we don't want to > > preload the compiler, so we want to pre-compile the dispatchers used > > by the preloaded code. > > > >> but I am not sure it is the way to do. > > > > `cl--generic-prefill-dispatchers` is not guaranteed to be defined when > > we load `register.el` (it's only defined if we loaded the non-compiled > > version of `cl-generic.el`) so the above call should be in > > `cl-generic.el` rather than in `register.el`. > > > > I'd put it next to the following block: > > > > (cl--generic-prefill-dispatchers 0 (eql nil)) > > (cl--generic-prefill-dispatchers window-system (eql nil)) > > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--get-selection) > > (eql nil)) > > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--set-selection) > > (eql nil)) > > > > which is already about dispatchers needed to support other files. > > I will for now leave the call to `cl--generic-prefill-dispatchers` in > the patch as a reminder that it should be added instead in cl-defgeneric > once merging. I tried to install the patch, but it fails to compile: ELC ../lisp/register.elc In toplevel form: register.el:33:37: Warning: `eql' called with 1 argument, but requires 2 register.el:33:45: Warning: reference to free variable `integer' This then fails the build, since 'register' is preloaded. Thierry, can you please fix the code, so that I could install it? Or what am I missing? P.S. Also, the log message is not according to our conventions.