From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Mon, 11 Dec 2023 14:05:51 +0200 Message-ID: <83o7exueow.fsf@gnu.org> References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27304"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66732@debbugs.gnu.org, dominik@honnef.co To: Yuan Fu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 13:07:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCf3v-0006tP-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 13:07:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCf3i-0004QY-B9; Mon, 11 Dec 2023 07:06:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCf3g-0004Q4-3T for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:06:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCf3f-000293-Rs for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:06:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCf3u-00066v-Hi for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170229639023433 (code B ref 66732); Mon, 11 Dec 2023 12:07:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 11 Dec 2023 12:06:30 +0000 Original-Received: from localhost ([127.0.0.1]:52816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCf3O-00065t-1I for submit@debbugs.gnu.org; Mon, 11 Dec 2023 07:06:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCf3L-00065f-BV for 66732@debbugs.gnu.org; Mon, 11 Dec 2023 07:06:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCf2z-000265-Gr; Mon, 11 Dec 2023 07:06:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mRoMbc3D0hTQeevB0+3PP8I5QTIQ43OWZ7ISemGqjU4=; b=eqXI5U9pgrtXMK14qUTY MraxdXYvPtO8Sl33/6EUpQft2J1Z6uVrjVvar0e3RCmvzBVzRA3wHm7eg4oHyRvDSPzOxBBRrOaRu 6DfevzcRnTq+XoZaisbOs+m9ww0oKrpGI12Me4nWmpDoA3F0NxjA6D87HV3r304NgN22krjYuX3mc ZYw4uPZPJnPniQy16nGwWtiNXaLjd1PzqedPK4/Xj7nroEmbp/plh5dbvCjFtHt6WQRqWLras9Kxm VionzNxATAdujzzTRffAHoqbTASmcnew9WSDQaIq0S4u03s8AQZ+SpgS/5ULbVFWC9ObbtKeMIFNh xxIUt67rjEk+tg==; In-Reply-To: <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> (message from Yuan Fu on Sun, 10 Dec 2023 20:16:37 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275979 Archived-At: > Date: Sun, 10 Dec 2023 20:16:37 -0800 > Cc: dmitry@gutov.dev, 66732@debbugs.gnu.org, dominik@honnef.co > From: Yuan Fu > > (defun treesit--font-lock-notifier (ranges parser) >   "Ensures updated parts of the parse-tree are refontified. > RANGES is a list of (BEG . END) ranges, PARSER is the tree-sitter > parser notifying of the change." >   (with-current-buffer (treesit-parser-buffer parser) >     (dolist (range ranges) >       (when treesit--font-lock-verbose >         (message "Notifier received range: %s-%s" >                  (car range) (cdr range))) >       (with-silent-modifications >         (put-text-property (car range) (cdr range) 'fontified nil))))) > > This notifier function will be called during redisplay [1]. I suspect > that because of this timing, redisplay doesn't refontify the marked > region immediately. So I added a timer, I think that ensures we mark the > affected region in the next command loop? > > (defun treesit--font-lock-notifier (ranges parser) >   "Ensures updated parts of the parse-tree are refontified. > RANGES is a list of (BEG . END) ranges, PARSER is the tree-sitter > parser notifying of the change." >   (with-current-buffer (treesit-parser-buffer parser) >     (dolist (range ranges) >       (when treesit--font-lock-verbose >         (message "Notifier received range: %s-%s" >                  (car range) (cdr range))) >       (run-with-timer >        0 nil >        (lambda () >          (with-silent-modifications >            (put-text-property (car range) (cdr range) >                               'fontified nil))))))) > > This seems to work. Eli, do you see any problem using run-with-timer > this way? Why do you ask? is there something in this function that bothers you? What's the correct way to mark some region unfontified? > [1] The chain of events if roughly: user types the last "/" -> redisplay > -> fontify that character -> access parser -> parser reparses -> calls > notifier. The way to mark region of text as not fontified is to set its 'fontified' property nil. Instead of a timer, did you try to use pre-redisplay-function? I added Stefan, in case he has some suggestions and ideas.