From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68114: [PATCH] Make 'advice-remove' interactive Date: Sat, 06 Jan 2024 18:48:20 +0200 Message-ID: <83o7dys90r.fsf@gnu.org> References: <87r0j42353.fsf@stebalien.com> <83a5ps6a5e.fsf@gnu.org> <87r0j491mx.fsf@stebalien.com> <837ckw5gug.fsf@gnu.org> <87r0j3hcir.fsf@stebalien.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15159"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68114@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 06 17:49:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rM9r7-0003n7-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jan 2024 17:49:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM9r1-0006PO-Kw; Sat, 06 Jan 2024 11:48:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM9r0-0006Lu-28 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 11:48:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rM9qz-00032u-49 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 11:48:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rM9r3-00088o-Hp for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 11:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2024 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68114-submit@debbugs.gnu.org id=B68114.170455972531207 (code B ref 68114); Sat, 06 Jan 2024 16:49:01 +0000 Original-Received: (at 68114) by debbugs.gnu.org; 6 Jan 2024 16:48:45 +0000 Original-Received: from localhost ([127.0.0.1]:60234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM9qm-00087D-TB for submit@debbugs.gnu.org; Sat, 06 Jan 2024 11:48:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM9qj-00086H-7i for 68114@debbugs.gnu.org; Sat, 06 Jan 2024 11:48:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM9qX-0002Xq-RS; Sat, 06 Jan 2024 11:48:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vKtsCCTCb/ybTJBDaKWH9QCqZ2CQEUdDbfHQZNAlFdU=; b=dGaf3HLEsThQ Lb0VftWOEsOqCuHxcw0fhTtKxOSO0Pn3JzNLMs6zkoKr/NQr1Ynf5ExB283GMA484Y0c78pfX4f8t 44+Sjf1Wquu11u/sYwKJoxr3MOuxevlThMVBe/vYFUn2UbLF4qqsCxAlgsj5L6IkvkFihe+5D0PQV LlVpg7HdWzwpBfJFPP5Je0uAyyIF2S1KNpbgDFKrais3QNt09Lg224S9ZccSWQVN0Dr9ZutZaZ2R/ H5QvpJWPoWqc6hhsUoeX/PwtlINcD/uOAlHrJIvskfbOaEY17j6zrFigAVrTXxKa2ieUGon7vcl0B hq00fJhULjIIgY8HG8KnGg==; In-Reply-To: <87r0j3hcir.fsf@stebalien.com> (message from Steven Allen on Sat, 30 Dec 2023 08:37:48 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277470 Archived-At: > From: Steven Allen > Date: Sat, 30 Dec 2023 08:37:48 -0800 > > Ah, I responded to the previous message before seeing this one. I installed this patch, thanks. > > Btw, what is "the 'name' of a piece of advice"? I realize that this > > text was there to begin with, but I don't think I understand what it > > wants to tell me, so maybe we could clarify that. The only reference > > to a "name" in the preceding text uses "name" to mean a symbol, but > > then what is "the name of a piece of advice"? I guess this goes back > > to define-advice, which says: > > > > @defmac define-advice symbol (where lambda-list &optional name depth) &rest body > > This macro defines a piece of advice and adds it to the function named > > @var{symbol}. The advice is an anonymous function if @var{name} is > > @code{nil} or a function named @code{symbol@@name}. See > > @code{advice-add} for explanation of other arguments. > > > > which is also a bit mysterious. Does NAME used here serve as "the > > name of the piece of advice"? if so, should "@code{symbol@@name}" be > > "@code{symbol@@@var{name}}" instead, i.e. "name" is not a literal > > string but the reference to NAME? > > So, those two names are actually different. The 'name' in referenced in > the `advice-remove` documentation is the 'name in the advice's 'props' > alist. The 'name' specified in `define-advice` is _not_ added to this > alist and is only used in the advice's function name. > > I'm happy to resolve this in a separate patch, if that's OK with you. > Something like (`define-advice` documentation): > > Note if NAME is nil the advice is anonymous; otherwise the advice > function is named `SYMBOL@NAME' and the advice is named NAME. > > Then actually add NAME to the properties. Yes, I think something like this should be installed.