From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Include guards
Date: Thu, 08 Jul 2010 23:32:45 +0300
Message-ID: <83mxu1btoy.fsf@gnu.org>
References: <83hbk97tj0.fsf@gnu.org> <yxq1vbdrerv.fsf@fencepost.gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1278621313 3388 80.91.229.12 (8 Jul 2010 20:35:13 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Thu, 8 Jul 2010 20:35:13 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Dan Nicolaescu <dann@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 08 22:35:09 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1OWxoJ-0005Ot-NO
	for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 22:35:07 +0200
Original-Received: from localhost ([127.0.0.1]:54244 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1OWxoJ-0004xO-5d
	for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 16:35:07 -0400
Original-Received: from [140.186.70.92] (port=45038 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWxoC-0004wa-84
	for emacs-devel@gnu.org; Thu, 08 Jul 2010 16:35:01 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <eliz@gnu.org>) id 1OWxo6-0000pL-N1
	for emacs-devel@gnu.org; Thu, 08 Jul 2010 16:35:00 -0400
Original-Received: from mtaout20.012.net.il ([80.179.55.166]:60480)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <eliz@gnu.org>)
	id 1OWxo4-0000oh-Gm; Thu, 08 Jul 2010 16:34:52 -0400
Original-Received: from conversion-daemon.a-mtaout20.012.net.il by
	a-mtaout20.012.net.il (HyperSendmail v2007.08) id
	<0L5900500AHKFX00@a-mtaout20.012.net.il>;
	Thu, 08 Jul 2010 23:34:45 +0300 (IDT)
Original-Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout20.012.net.il
	(HyperSendmail v2007.08) with ESMTPA id
	<0L5900M2XAHWH6G0@a-mtaout20.012.net.il>;
	Thu, 08 Jul 2010 23:34:45 +0300 (IDT)
In-reply-to: <yxq1vbdrerv.fsf@fencepost.gnu.org>
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:126920
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/126920>

> Cc: emacs-devel@gnu.org
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Thu, 08 Jul 2010 14:48:20 -0400
> 
> >   . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
> >     it.
> 
> scroll.c has been including string.h unguarded for quite a while.  If
> that was a problem on any supported platform, we would have heard about it.
> So the include guard is not needed, better remove it.

OK, but then we should also remove it from config.in and configure.in.