From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7728: 24.0.50; GDB backtrace from abort Date: Tue, 11 Jan 2011 23:14:26 +0200 Message-ID: <83mxn7i1n1.fsf@gnu.org> References: <30041A5C411E45A7B7AF7A9ECA3AA0BE@us.oracle.com> <83y67echvm.fsf@gnu.org> <837heopknq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1294781755 19215 80.91.229.12 (11 Jan 2011 21:35:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 11 Jan 2011 21:35:55 +0000 (UTC) Cc: 7728@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 11 22:35:50 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pclsb-0003Cj-P3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jan 2011 22:35:50 +0100 Original-Received: from localhost ([127.0.0.1]:53785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcloZ-0007eN-GY for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jan 2011 16:31:39 -0500 Original-Received: from [140.186.70.92] (port=51027 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PclhR-00041V-Sw for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2011 16:24:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PclhN-0000kO-1B for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2011 16:24:17 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PclhM-0000kA-VZ for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2011 16:24:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PclRh-0007Cu-RU; Tue, 11 Jan 2011 16:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2011 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7728-submit@debbugs.gnu.org id=B7728.129478002627625 (code B ref 7728); Tue, 11 Jan 2011 21:08:01 +0000 Original-Received: (at 7728) by debbugs.gnu.org; 11 Jan 2011 21:07:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PclQn-0007BW-SV for submit@debbugs.gnu.org; Tue, 11 Jan 2011 16:07:06 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PclQk-0007B1-Se for 7728@debbugs.gnu.org; Tue, 11 Jan 2011 16:07:04 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LEV00100MTFRJ00@a-mtaout21.012.net.il> for 7728@debbugs.gnu.org; Tue, 11 Jan 2011 23:14:30 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.131.253]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LEV001VGMZZAOB0@a-mtaout21.012.net.il>; Tue, 11 Jan 2011 23:14:25 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 11 Jan 2011 16:08:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43264 Archived-At: > From: Stefan Monnier > Cc: drew.adams@oracle.com, 7728@debbugs.gnu.org > Date: Tue, 11 Jan 2011 15:55:12 -0500 > > There's still one thing I don't understand: why do we call > Fselect_frame? AFAICT, Fset_window_configuration has no reason to > select a new frame, it all works within the selected-frame. Probably because of minibuffer-only frames or something. Perhaps Drew could publish the relevant parts of the window configuration that was being restored in that case (or any other similar case). > > So I see 2 ways to prevent this particular problem: > > 1) Handle the case of selected_window == Qnil in > > CURRENT_MODE_LINE_FACE_ID. > > But should it always return the mode-line-inactive face here, or should > it always return the mode-line face? I don't think it matters much, since if we don't have a window to work with, we are only guesstimating anyway. > > 2) Change the code of Fset_window_configuration and Fselect_window, > > to have some other way of preventing the latter from storing point > > in the old selected window, without setting selected_window to > > nil. > > That sounds like a better solution. E.g. move the code of > Fselect_window to another function, add a third argument to it > specifying whether to swap-out point in selected_window, and make > Fset_window_configuration call that new internal function. Yes, something like that.