all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Christoph <cschol2112@googlemail.com>
Cc: emacs-devel@gnu.org
Subject: Re: How many more gnulib imports?
Date: Sun, 20 Feb 2011 19:28:13 +0200	[thread overview]
Message-ID: <83mxlqty36.fsf@gnu.org> (raw)
In-Reply-To: <4D613DB1.9030705@gmail.com>

> Date: Sun, 20 Feb 2011 09:13:37 -0700
> From: Christoph <cschol2112@googlemail.com>
> CC: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>, 
>  emacs-devel@gnu.org
> 
> On 2/20/2011 8:56 AM, I wrote:
> 
> > In regards to the md5 change, I think I have a patch to fix the Windows
> > build. I will send it for review once my bootstrap finishes and I see
> > everything works. Shouldn't be too long.
> 
> Find the patch fixing the Windows build for including lib/md5.c attached.

Thanks.  Please install this in the repository as soon as you can.

However, this change will only work with MinGW, since it has stdint.h.
To make it work with MSVC, we need to add nt/inc/stdint.h, and make
lib/md5.$(O) depend on it.  For MinGW, nt/inc/stdint.h could just say
"#include_next <stdint.h>" (conditioned on __GNUC__ being non-zero).
Otherwise, it should include the minimum needed for md5.c to compile.
Paul said a few messages ago that all that's needed for now is this:

   typedef unsigned int uint32_t;

Could you please commit such a followup change, after you test it (see
below)?  If not, I will get to it in due time.

To test this change (assuming you don't have MSVC -- neither do I,
btw), rename MinGW's stdint.h in the MinGW include directory, create
an nt/inc/stdint.h that has just the above 1 line, and then try
building with MinGW.  Any compilation error/warning you see probably
means that more stuff needs to be added to nt/inc/stdint.h.

Thanks a lot for your help.



  reply	other threads:[~2011-02-20 17:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20 11:17 draft patch to import gnulib's filemode module into Emacs Paul Eggert
2011-02-20 12:42 ` Eli Zaretskii
2011-02-20 17:18   ` Paul Eggert
2011-02-21 17:58     ` Paul Eggert
2011-02-20 12:43 ` How many more gnulib imports? (was: draft patch to import gnulib's filemode module into Emacs) Eli Zaretskii
2011-02-20 15:56   ` How many more gnulib imports? Christoph
2011-02-20 16:13     ` Christoph
2011-02-20 17:28       ` Eli Zaretskii [this message]
2011-02-20 17:54         ` Christoph
2011-02-20 18:54           ` Eli Zaretskii
2011-02-20 23:32         ` Christoph
2011-02-21 16:00           ` Christoph
2011-02-21 19:05           ` Eli Zaretskii
2011-02-21 19:10             ` Christoph
2011-02-21 20:19               ` Eli Zaretskii
2011-02-21 20:21             ` Eli Zaretskii
2011-02-20 17:46   ` Paul Eggert
2011-02-20 17:54     ` Eli Zaretskii
2011-02-20 18:06       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mxlqty36.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cschol2112@googlemail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.