From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11365: 24.1.50; quitting gdb does not restore window configuration Date: Wed, 02 May 2012 19:02:56 +0300 Message-ID: <83mx5qsh8v.fsf@gnu.org> References: <87zk9xqarc.fsf@gnu.org> <4F9BA973.1030806@gmx.at> <4F9F9A1D.3010605@gmx.at> <83zk9rsxpv.fsf@gnu.org> <4FA100F3.5090102@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1335974622 16528 80.91.229.3 (2 May 2012 16:03:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 May 2012 16:03:42 +0000 (UTC) Cc: 11365@debbugs.gnu.org, sds@gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 02 18:03:41 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SPc1k-0001ub-RR for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2012 18:03:40 +0200 Original-Received: from localhost ([::1]:40012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPc1j-00015F-RG for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2012 12:03:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPc1b-00014p-Mn for bug-gnu-emacs@gnu.org; Wed, 02 May 2012 12:03:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPc1Z-0006SP-Q9 for bug-gnu-emacs@gnu.org; Wed, 02 May 2012 12:03:31 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPc1Z-0006SL-Mn for bug-gnu-emacs@gnu.org; Wed, 02 May 2012 12:03:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SPc34-0006sB-9G for bug-gnu-emacs@gnu.org; Wed, 02 May 2012 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 May 2012 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11365-submit@debbugs.gnu.org id=B11365.133597469526405 (code B ref 11365); Wed, 02 May 2012 16:05:02 +0000 Original-Received: (at 11365) by debbugs.gnu.org; 2 May 2012 16:04:55 +0000 Original-Received: from localhost ([127.0.0.1]:33941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPc2x-0006rp-8s for submit@debbugs.gnu.org; Wed, 02 May 2012 12:04:55 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49050) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPc2u-0006rc-UR for 11365@debbugs.gnu.org; Wed, 02 May 2012 12:04:54 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M3E00200KK2HN00@a-mtaout22.012.net.il> for 11365@debbugs.gnu.org; Wed, 02 May 2012 19:02:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.228.21.115]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M3E002P4KKEEG10@a-mtaout22.012.net.il>; Wed, 02 May 2012 19:02:39 +0300 (IDT) In-reply-to: <4FA100F3.5090102@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59706 Archived-At: > Date: Wed, 02 May 2012 11:40:03 +0200 > From: martin rudalics > CC: sds@gnu.org, 11365@debbugs.gnu.org > > > The function to look at is gdb-reset. > > (gdb-delete-frame-or-window is just what causes GDB to quit, but when > > it actually does, the comint process sentinel kicks in and calls > > gdb-reset.) But for gdb-reset to do what Sam wants, gdb-setup-windows > > should record the configuration of windows before it sets up the GDB > > windows, otherwise we will have no information about the previous > > window configuration. > > I fail to understand you. The window configuration *is* handled by > `gdb-delete-frame-or-window'. What should `gdb-reset' do about it and > when? IIUC Sam wants `gdb-delete-frame-or-window' restore a previous > configuration. It is IMO wrong to do what Sam wants in gdb-delete-frame-or-window. That's because the restoration of the window configuration should be done when GDB actually exits, not when the user _tells_ GDB to exit. The function which handles the exit event is gdb-reset.