bug#12050: 23.3; font trashes mode-line file name

bug#12050: 23.3; font trashes mode-line file name

[joseph]

From: joseph patterson <joseph@photosessionsltd.com>
To: bug-gnu-emacs@gnu.org
Subject: 23.3; font trashes mode-line file name
--text follows this line--
This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your report will be posted to the bug-gnu-emacs@gnu.org mailing list
and the gnu.emacs.bug news group, and at http://debbugs.gnu.org.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

emacs -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15 anyfile

The mode-line display of the file name is trashed. It consists of a
sequence of small narrow empty rectangles. The mode and line number are
legible and not trashed.
This problem did not happen in version 22 of emacs. This font is used
satisfactorily in the mode-line in version 22 of emacs.

If I do an esc-x-list-buffers, then the list of buffers has the
file names trashed similar to the file name in the mode-line.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/share/emacs/23.3/etc/DEBUG.


In GNU Emacs 23.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.5)
 of 2011-08-14 on rothera, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--build' 'i686-linux-gnu' '--build'
'i686-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib'
'--libexecdir=/usr/lib' '--localstatedir=/var/lib'
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.3/leim'
'--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes'
'--with-x-toolkit=gtk' '--with-toolkit-scroll-bars'
'build_alias=i686-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g'
'CPPFLAGS=''

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: en_US.UTF-8
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f r e a d m e <return> C-x C-f <return> C-n C-n
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-p <return> C-x C-f <return> C-n <return> C-x
C-f <return> C-n <return> C-x C-f <return> C-x C-f
<return> C-x C-f C-h C-h C-b C-b C-b C-b C-b C-k <return>
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-l C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-n C-n C-n C-n C-n C-p <return> C-x
C-b C-x o C-n d d d d d d d d d x C-x o <escape> x
r e p o r e <backspace> t <tab> <return>

Recent messages:
byte-code: Text is read-only

Load-path shadows:
/usr/share/emacs/23.3/site-lisp/debian-startup hides
/usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs23/site-lisp/flim/sha1 hides /usr/share/emacs/23.3/lisp/sha1
/usr/share/emacs23/site-lisp/flim/md4 hides /usr/share/emacs/23.3/lisp/md4
/usr/share/emacs23/site-lisp/flim/hex-util hides
/usr/share/emacs/23.3/lisp/hex-util
/usr/share/emacs23/site-lisp/dictionaries-common/ispell hides
/usr/share/emacs/23.3/lisp/textmodes/ispell
/usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides
/usr/share/emacs/23.3/lisp/textmodes/flyspell
/usr/share/emacs23/site-lisp/flim/sasl-ntlm hides
/usr/share/emacs/23.3/lisp/net/sasl-ntlm
/usr/share/emacs23/site-lisp/flim/ntlm hides
/usr/share/emacs/23.3/lisp/net/ntlm
/usr/share/emacs23/site-lisp/flim/sasl-cram hides
/usr/share/emacs/23.3/lisp/net/sasl-cram
/usr/share/emacs23/site-lisp/flim/hmac-md5 hides
/usr/share/emacs/23.3/lisp/net/hmac-md5
/usr/share/emacs23/site-lisp/flim/hmac-def hides
/usr/share/emacs/23.3/lisp/net/hmac-def
/usr/share/emacs23/site-lisp/flim/sasl hides
/usr/share/emacs/23.3/lisp/net/sasl
/usr/share/emacs23/site-lisp/flim/sasl-digest hides
/usr/share/emacs/23.3/lisp/net/sasl-digest

Features:
(shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
sha1-el hex-util hashcash mail-utils emacsbug help-mode easymenu view
dired regexp-opt debian-el debian-el-loaddefs dpkg-dev-el
dpkg-dev-el-loaddefs devhelp tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs)

bug#12050: 23.3; font trashes mode-line file name

[Eli Zaretskii]

> Date: Wed, 25 Jul 2012 02:02:41 -0400
> From: joseph@photosessionsltd.com
> 
> emacs -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15 anyfile
> 
> The mode-line display of the file name is trashed. It consists of a
> sequence of small narrow empty rectangles. The mode and line number are
> legible and not trashed.
> This problem did not happen in version 22 of emacs. This font is used
> satisfactorily in the mode-line in version 22 of emacs.

Can you please try this in Emacs 24.1, the current version?

bug#12050: 23.3; font trashes mode-line file name

[Eli Zaretskii]

> Date: Thu, 26 Jul 2012 08:28:05 -0400
> From: joseph@photosessionsltd.com
> 
> I built emacs-24.1 in a local directory and tried it with the same command
> line. I find emacs-23.3 is decidedly more friendly than emacs-24.1. 23.3
> merely trashes the filename in the mode-line. 24.1 gives
> Fatal error (11) Segmentation fault.
> 
> I can invoke emacs-24.1 with some alternative not default font and it does
> come up ok and display file names in the mode line. The following line
> with a helvetica font displays ok in emacs23.3 (i.e., mode-line fine). The
> following line gives Fatal error (11) Segmentation fault with emacs-24.1.
> 
> emacs -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15 anyfile

I think this problem was already fixed in the development sources.
But before I send you the change that fixed it, could you please run
Emacs under a debugger and see in what source line does it crash?  I'd
like to verify that what you see is the same problem as the one that
was fixed.

Thanks.

P.S. Please keep the bug address on the CC line, so that this
discussion is archived on the bug tracker.

bug#12050: 23.3; font trashes mode-line file name

[joseph]

with the gdb command
run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
the crash occurs at xterm.c:1216
1216   else if (FONT_HEIGHT (s->font) < s->height - 2 * box_line_width

with the gdb command
run -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
the crash occurs at xfaces.c:4841
4841   if (! EQ (face->font->props[i], def_face->font->props[i]))

recall that the times line crashes in 23.3 and 24.1 and the helvetica line
works fine in 23.3 and crashes in 24.1.


>> Date: Thu, 26 Jul 2012 08:28:05 -0400
>> From: joseph@photosessionsltd.com
>>
>> I built emacs-24.1 in a local directory and tried it with the same
>> command
>> line. I find emacs-23.3 is decidedly more friendly than emacs-24.1. 23.3
>> merely trashes the filename in the mode-line. 24.1 gives
>> Fatal error (11) Segmentation fault.
>>
>> I can invoke emacs-24.1 with some alternative not default font and it
>> does
>> come up ok and display file names in the mode line. The following line
>> with a helvetica font displays ok in emacs23.3 (i.e., mode-line fine).
>> The
>> following line gives Fatal error (11) Segmentation fault with
>> emacs-24.1.
>>
>> emacs -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
>> anyfile
>
> I think this problem was already fixed in the development sources.
> But before I send you the change that fixed it, could you please run
> Emacs under a debugger and see in what source line does it crash?  I'd
> like to verify that what you see is the same problem as the one that
> was fixed.
>
> Thanks.
>
> P.S. Please keep the bug address on the CC line, so that this
> discussion is archived on the bug tracker.
>

bug#12050: 23.3; font trashes mode-line file name

[Eli Zaretskii]

> Date: Sun, 29 Jul 2012 07:44:16 -0400
> From: joseph@photosessionsltd.com
> 
> with the gdb command
> run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
> the crash occurs at xterm.c:1216
> 1216   else if (FONT_HEIGHT (s->font) < s->height - 2 * box_line_width

This is fixed in the development sources, patch below.

> with the gdb command
> run -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
> the crash occurs at xfaces.c:4841
> 4841   if (! EQ (face->font->props[i], def_face->font->props[i]))

Why does this crash? is def_face->font a NULL pointer or something?

> recall that the times line crashes in 23.3 and 24.1 and the helvetica line
> works fine in 23.3 and crashes in 24.1.

Note that both fonts are bold.  If you use the non-bold variant of the
same font, does the problem go away?

--- src/xdisp.c	2012-07-07 21:39:45 +0000
+++ src/xdisp.c	2012-07-08 15:49:39 +0000
@@ -22736,7 +22736,7 @@ fill_glyphless_glyph_string (struct glyp
   last = s->row->glyphs[s->area] + end;
   voffset = glyph->voffset;
   s->face = FACE_FROM_ID (s->f, face_id);
-  s->font = s->face->font;
+  s->font = s->face->font ? s->face->font : FRAME_FONT (s->f);
   s->nchars = 1;
   s->width = glyph->pixel_width;
   glyph++;

bug#12050: 23.3; font trashes mode-line file name

[joseph]

with src/xdisp.c 22736 fix (24.1 line numbers differ by ~300 but context
is correct):

run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
does not crash emacs but mode-line is completely undecipherable. each char
appears to have an octal representation of a char inside a rectangular box

run -q -fn -adobe-times-medium-r-normal--0-0-0-0-p-0-iso8859-15
crash at
xfaces.c:4841
4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
(gdb) print def_face->font
$2 = (struct font *) 0x0

run -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
crash at
xfaces.c:4841
4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
(gdb) print def_face->font
$2 = (struct font *) 0x0

run -q -fn -adobe-helvetica-medium-r-normal--0-0-0-0-p-0-iso8859-15
crash at
xfaces.c:4841
4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
(gdb) print def_face->font
$2 = (struct font *) 0x0


>> Date: Sun, 29 Jul 2012 07:44:16 -0400
>> From: joseph@photosessionsltd.com
>>
>> with the gdb command
>> run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
>> the crash occurs at xterm.c:1216
>> 1216   else if (FONT_HEIGHT (s->font) < s->height - 2 * box_line_width
>
> This is fixed in the development sources, patch below.
>
>> with the gdb command
>> run -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
>> the crash occurs at xfaces.c:4841
>> 4841   if (! EQ (face->font->props[i], def_face->font->props[i]))
>
> Why does this crash? is def_face->font a NULL pointer or something?
>
>> recall that the times line crashes in 23.3 and 24.1 and the helvetica
>> line
>> works fine in 23.3 and crashes in 24.1.
>
> Note that both fonts are bold.  If you use the non-bold variant of the
> same font, does the problem go away?
>
> --- src/xdisp.c	2012-07-07 21:39:45 +0000
> +++ src/xdisp.c	2012-07-08 15:49:39 +0000
> @@ -22736,7 +22736,7 @@ fill_glyphless_glyph_string (struct glyp
>    last = s->row->glyphs[s->area] + end;
>    voffset = glyph->voffset;
>    s->face = FACE_FROM_ID (s->f, face_id);
> -  s->font = s->face->font;
> +  s->font = s->face->font ? s->face->font : FRAME_FONT (s->f);
>    s->nchars = 1;
>    s->width = glyph->pixel_width;
>    glyph++;
>
>

bug#12050: 23.3; font trashes mode-line file name

[Eli Zaretskii]

> Date: Mon, 30 Jul 2012 04:20:11 -0400
> From: joseph@photosessionsltd.com
> Cc: 12050@debbugs.gnu.org
> 
> with src/xdisp.c 22736 fix (24.1 line numbers differ by ~300 but context
> is correct):
> 
> run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
> does not crash emacs but mode-line is completely undecipherable. each char
> appears to have an octal representation of a char inside a rectangular box
> 
> run -q -fn -adobe-times-medium-r-normal--0-0-0-0-p-0-iso8859-15
> crash at
> xfaces.c:4841
> 4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
> (gdb) print def_face->font
> $2 = (struct font *) 0x0
> 
> run -q -fn -adobe-helvetica-bold-r-normal--0-0-0-0-p-0-iso8859-15
> crash at
> xfaces.c:4841
> 4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
> (gdb) print def_face->font
> $2 = (struct font *) 0x0
> 
> run -q -fn -adobe-helvetica-medium-r-normal--0-0-0-0-p-0-iso8859-15
> crash at
> xfaces.c:4841
> 4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
> (gdb) print def_face->font
> $2 = (struct font *) 0x0

Thanks.

Would some font selection expert please chime in?  There's some weird
stuff going on with selecting a font for the mode line, and in
particular the buffer name there.

bug#12050: 23.3; font trashes mode-line file name

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

>> run -q -fn -adobe-helvetica-medium-r-normal--0-0-0-0-p-0-iso8859-15
>> crash at
>> xfaces.c:4841
>> 4841            if (! EQ (face->font->props[i], def_face->font->props[i]))
>> (gdb) print def_face->font
>> $2 = (struct font *) 0x0
>
> Thanks.
>
> Would some font selection expert please chime in?  There's some weird
> stuff going on with selecting a font for the mode line, and in
> particular the buffer name there.

I don't have Adobe Helvetica, so I can't debug this.  None of the fonts
available on my system seem to cause such problems.

bug#12050: 23.3; font trashes mode-line file name

[Lars Ingebrigtsen]

joseph@photosessionsltd.com writes:

> with src/xdisp.c 22736 fix (24.1 line numbers differ by ~300 but context
> is correct):
>
> run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
> does not crash emacs but mode-line is completely undecipherable. each char
> appears to have an octal representation of a char inside a rectangular box

Are you still seeing these problems in modern versions of Emacs?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#12050: 23.3; font trashes mode-line file name

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> joseph@photosessionsltd.com writes:
>
>> with src/xdisp.c 22736 fix (24.1 line numbers differ by ~300 but context
>> is correct):
>>
>> run -q -fn -adobe-times-bold-r-normal--0-0-0-0-p-0-iso8859-15
>> does not crash emacs but mode-line is completely undecipherable. each char
>> appears to have an octal representation of a char inside a rectangular box
>
> Are you still seeing these problems in modern versions of Emacs?

The reporter's mail address bounced, so I'm closing this bug report.  If
it's still an issue, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no