From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame. Date: Mon, 06 Aug 2012 19:42:37 +0300 Message-ID: <83mx289dky.fsf@gnu.org> References: <87boiocy9r.fsf@gnu.org> <501F81BE.3000604@yandex.ru> <501F8EC8.2060605@yandex.ru> <501FE70F.9040002@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1344271364 16842 80.91.229.3 (6 Aug 2012 16:42:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2012 16:42:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 06 18:42:44 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyQOA-0006EQ-Ap for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2012 18:42:42 +0200 Original-Received: from localhost ([::1]:57432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyQO9-0003GS-JY for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2012 12:42:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyQO6-00038O-2I for emacs-devel@gnu.org; Mon, 06 Aug 2012 12:42:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyQO5-0000Yw-9c for emacs-devel@gnu.org; Mon, 06 Aug 2012 12:42:38 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:56543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyQO5-0000YL-2U for emacs-devel@gnu.org; Mon, 06 Aug 2012 12:42:37 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M8C00300EE28I00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Mon, 06 Aug 2012 19:42:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8C0020BEEYYD60@a-mtaout22.012.net.il>; Mon, 06 Aug 2012 19:42:35 +0300 (IDT) In-reply-to: <501FE70F.9040002@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152227 Archived-At: This change in xmenu.c (and similar changes in nsmenu.m and w32menu.c that followed suit): - FRAME_MENU_BAR_ITEMS (f) = menu_bar_items (FRAME_MENU_BAR_ITEMS (f)); + FSET (f, menu_bar_items, menu_bar_items (FRAME_MENU_BAR_ITEMS (f))); exposed what was previously hidden behind the FRAME_MENU_BAR_ITEMS macro. Should we introduce a FRAME_SET_MENU_BAR_ITEMS macro instead?