From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 12170@debbugs.gnu.org, wbrodie@panix.com
Subject: bug#12170: save-excursion fails boundary case with recenter
Date: Sat, 11 Aug 2012 18:10:26 +0300 [thread overview]
Message-ID: <83mx21cvml.fsf@gnu.org> (raw)
In-Reply-To: <50266AAF.4000504@gmx.at>
> Date: Sat, 11 Aug 2012 16:22:39 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: wbrodie@panix.com, 12170@debbugs.gnu.org
>
> (progn
> (defmacro save-this-window-excursion (&rest body)
> "..."
> (let ((start (make-symbol "start"))
> (point (make-symbol "point")))
> `(let ((,start (copy-marker (window-start)))
> (,point (copy-marker (window-point))))
> (save-selected-window
> (progn ,@body))
> (set-window-start (selected-window) ,start t)
> (with-current-buffer (window-buffer (selected-window))
> (goto-char ,point)))))
>
> (defun f (n)
> (save-this-window-excursion (forward-line (- n)) (recenter 0)))
>
> (let ((buffer (switch-to-buffer "foo"))
> (height (1- (window-height (get-buffer-window "foo")))))
> (insert-char 10 (* height 2))
> (let ((pt (point)))
> (f height)
> (redisplay)
> (message "height %s old %s new %s" height pt (point)))))
>
> I get the same results as with `set-window-point'. IMHO the
> `set-window-start' call makes the difference but I don't understand why.
Maybe. If it's really important, I could try looking at this in the
debugger, although doing so to investigate such situations is
notoriously hard, because redisplay is entered several times.
IMO, save-excursion is simply not designed to make sure display isn't
changed in such cases. It's for excursions into other portions of the
buffer for processing those other parts, without affecting display.
If the processing also scrolls the screen or calls recenter or
otherwise affects the display, all bets are off, because scrolling can
legitimately move point, and when that happens, it is no longer clear
that restoring point should take precedence over window-start etc.
next prev parent reply other threads:[~2012-08-11 15:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 1:23 bug#12170: save-excursion fails boundary case with recenter Bill Brodie
2012-08-10 9:34 ` martin rudalics
2012-08-10 9:50 ` Bastien
2012-08-10 13:03 ` martin rudalics
2012-08-10 13:40 ` Bill Brodie
2012-08-10 14:47 ` martin rudalics
2012-08-10 16:18 ` Stefan Monnier
2012-08-10 16:47 ` martin rudalics
2012-08-10 17:07 ` Stefan Monnier
2012-08-10 19:01 ` Eli Zaretskii
2012-08-11 9:32 ` martin rudalics
2012-08-11 11:11 ` Eli Zaretskii
2012-08-11 14:22 ` martin rudalics
2012-08-11 15:10 ` Eli Zaretskii [this message]
2012-08-11 16:05 ` martin rudalics
2012-08-11 16:31 ` Eli Zaretskii
2012-08-11 16:49 ` Eli Zaretskii
2012-08-12 10:31 ` martin rudalics
2012-08-11 16:27 ` Bill Brodie
2012-08-10 15:04 ` Stefan Monnier
2012-08-10 15:46 ` Bill Brodie
2012-08-10 16:46 ` martin rudalics
2012-08-10 16:46 ` martin rudalics
2012-08-10 18:58 ` Eli Zaretskii
2012-08-11 9:31 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mx21cvml.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12170@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=wbrodie@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.