From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117912: Minor improvements to new stack-allocated Lisp objects.
Date: Mon, 22 Sep 2014 17:44:19 +0300 [thread overview]
Message-ID: <83mw9ryat8.fsf@gnu.org> (raw)
In-Reply-To: <541FC4DB.3050307@yandex.ru>
> Date: Mon, 22 Sep 2014 10:42:35 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Cc: emacs-devel@gnu.org
>
> > We should also audit uses of make_local_vector, make_local_string, and build_local_string to make sure
> > that none of them are in loops that could blow the stack. I think most uses of these are OK but
> > some are questionable.
>
> SAFE_ALLOCA and friends has exactly the same problems, and I don't see the way to make it
> absolutely safe with an existing implementations of alloca. This applies to VLAs as well.
We indeed have a few calls to SAFE_ALLOCA and SAFE_NALLOCA inside loops.
> Someday we will be able to utilize -fsplit-stack; it may be reasonable to define
> USE_LOCAL_LISP_OBJECTS only if -fsplit-stack is also supported.
AFAIU, -fsplit-stack is a mixed blessing at best when calling code
that was not compiled with that switch (a.k.a. "external libraries").
next prev parent reply other threads:[~2014-09-22 14:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XVpwf-0005xe-7w@vcs.savannah.gnu.org>
2014-09-22 5:08 ` [Emacs-diffs] trunk r117912: Minor improvements to new stack-allocated Lisp objects Stefan Monnier
2014-09-22 5:40 ` Paul Eggert
2014-09-22 6:42 ` Dmitry Antipov
2014-09-22 8:19 ` Dmitry Antipov
2014-09-22 12:57 ` Stefan Monnier
2014-09-22 15:00 ` Eli Zaretskii
2014-09-22 14:44 ` Eli Zaretskii [this message]
2014-09-22 15:32 ` Paul Eggert
2014-09-22 16:04 ` Dmitry Antipov
2014-09-22 19:09 ` Eli Zaretskii
2014-09-23 5:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mw9ryat8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.