From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19481: package.el: support .tar archives featuring a pax_global_header entry Date: Sat, 31 Jan 2015 13:22:21 +0200 Message-ID: <83mw4zjitu.fsf@gnu.org> References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1422703400 2458 80.91.229.3 (31 Jan 2015 11:23:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Jan 2015 11:23:20 +0000 (UTC) Cc: 19481@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 31 12:23:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHW8w-0005B9-JV for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 12:23:14 +0100 Original-Received: from localhost ([::1]:40286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHW8v-0000FZ-D3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 06:23:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHW8q-0000FD-R6 for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:23:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHW8k-0000F0-TQ for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:23:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHW8k-0000Ew-Qe for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YHW8k-0002eD-C7 for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jan 2015 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19481-submit@debbugs.gnu.org id=B19481.142270335110131 (code B ref 19481); Sat, 31 Jan 2015 11:23:02 +0000 Original-Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 11:22:31 +0000 Original-Received: from localhost ([127.0.0.1]:58472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHW8E-0002dL-NK for submit@debbugs.gnu.org; Sat, 31 Jan 2015 06:22:31 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:56671) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHW8B-0002d6-O4 for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 06:22:28 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NJ100M00GX90S00@a-mtaout21.012.net.il> for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 13:22:21 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ100M1RGX80R00@a-mtaout21.012.net.il>; Sat, 31 Jan 2015 13:22:21 +0200 (IST) In-reply-to: <87386ri50z.fsf_-_@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98930 Archived-At: > From: Ivan Shmakov > Date: Sat, 31 Jan 2015 11:05:48 +0000 > > >> * lisp/tar-mode.el (tar-header-extractable-p): New function. > >> (tar-untar-buffer): Use it; or use the value of the new optional > >> argument instead. > > >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use > >> tar-header-extractable-p. > >> (package-tar-file-info): Consider the second file name in the > >> archive if the first one has no directory component. > > > Thanks. > > > Can we have a test suite for this file, > > Which of the two? (Or three, to count the .tar file produced by > $ git archive.) I meant tar-mode.el, and specifically where the new function is used. > FTR, the two changes I suggest are not /inter/dependent, so I > intend to push them as two separate commits. Does the tar-header-extractable-p function make any sense without its use in package.el? If so, then yes, these should be 2 separate commits. > (And I wonder if > eit makes sense to now file a separate Severity: wishlist bug > report for tar-header-extractable-p, so to provide a somewhat > extended background for the feature.) Not sure it's worth your while. > > Failing that, please describe how you tested these changes. > > I’ve tested these using my MW package, like: > > • C-x b *new-buffer* RET; > > • M-x cd RET ~/devel/mw-el-2015/ RET; > > • C-u M-! git archive --prefix=mw-0.2/ --format=tar > HEAD 2> /dev/null RET; > > • M-x tar-mode RET; > > • M-x package-install-from-buffer RET. Did you try unpacking a "normal" tar archive, to see nothing is broken?