Re: Patch for Windows 8.1+ HiDPI support

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 13 May 2015 10:45:53 +0300
> From: Vitaly Takmazov <vitalyster@gmail.com>
> 
> Emacs works perfectly on HiDPI monitor, I have patched ony two minor things:
> 1) declare dpi-awareness in manifest files, so Windows will not enable
> "compatibility mode" and fonts now look crisp by default
> 2) remove unneeded OFN_ENABLEHOOK flag passed to GetOpenFileName, which allow
> OS to show modern "open file" dialog. Legacy dialog not support HiDPI mode and
> show too small icons.
> Let me know if I miss something and/or select wrong place to report it

Thanks.

> diff --git a/nt/emacs-x64.manifest b/nt/emacs-x64.manifest
> index 5434e29..3cf56dd 100644
> --- a/nt/emacs-x64.manifest
> +++ b/nt/emacs-x64.manifest
> @@ -1,5 +1,5 @@
>  <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> -<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
> +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">

Did you verify that these attributes don't produce any problems on
older versions of Windows?

> --- a/src/w32fns.c
> +++ b/src/w32fns.c
> @@ -6680,7 +6680,7 @@ value of DIR as in previous invocations; this is standard Windows behavior.  */)
>  #endif
>      file_details_w->nFilterIndex = NILP (only_dir_p) ? 1 : 2;
>      file_details_w->Flags = (OFN_HIDEREADONLY | OFN_NOCHANGEDIR
> -                 | OFN_EXPLORER | OFN_ENABLEHOOK);
> +                 | OFN_EXPLORER);

I don't see how can we remove this flag unconditionally, since we do
use a hook function, and for a good reason, AFAIR.  Won't removing the
flag break the functionality for which we use the callback function
there?  Did you try selecting "Directories" in the file chooser?