From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20628: 25.0.50; Incorrect line height for some fonts Date: Fri, 22 May 2015 17:07:56 +0300 Message-ID: <83mw0w4seb.fsf@gnu.org> References: <555E9C2E.8040008@live.com> <83617l5aox.fsf@gnu.org> <87pp5s2a77.fsf@gmail.com> <83wq004x2w.fsf@gnu.org> <83twv44vd3.fsf@gnu.org> <87egm87ny6.fsf@gmail.com> <83oalc4syu.fsf@gnu.org> <87617k7m5u.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1432303763 3215 80.91.229.3 (22 May 2015 14:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 May 2015 14:09:23 +0000 (UTC) Cc: clement.pitclaudel@live.com, 20628@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 22 16:09:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YvndO-0002ZS-U3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 May 2015 16:09:11 +0200 Original-Received: from localhost ([::1]:34194 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvndN-0003zz-QD for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 May 2015 10:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvndK-0003zj-2j for bug-gnu-emacs@gnu.org; Fri, 22 May 2015 10:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvndG-0001D0-SL for bug-gnu-emacs@gnu.org; Fri, 22 May 2015 10:09:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvndG-0001Cm-Oe for bug-gnu-emacs@gnu.org; Fri, 22 May 2015 10:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YvndG-0000S4-8l for bug-gnu-emacs@gnu.org; Fri, 22 May 2015 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 May 2015 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20628-submit@debbugs.gnu.org id=B20628.14323036881674 (code B ref 20628); Fri, 22 May 2015 14:09:02 +0000 Original-Received: (at 20628) by debbugs.gnu.org; 22 May 2015 14:08:08 +0000 Original-Received: from localhost ([127.0.0.1]:53022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YvncN-0000Qv-7b for submit@debbugs.gnu.org; Fri, 22 May 2015 10:08:07 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:34466) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YvncK-0000QQ-Q3 for 20628@debbugs.gnu.org; Fri, 22 May 2015 10:08:05 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NOR00M0084HYE00@mtaout25.012.net.il> for 20628@debbugs.gnu.org; Fri, 22 May 2015 17:03:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOR00FYU8EAKK70@mtaout25.012.net.il>; Fri, 22 May 2015 17:03:47 +0300 (IDT) In-reply-to: <87617k7m5u.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103028 Archived-At: > From: Oleh Krehel > Cc: clement.pitclaudel@live.com, 20628@debbugs.gnu.org > Date: Fri, 22 May 2015 15:54:21 +0200 > > I'm looking at xdisp.c now. When I set this: > > it->max_ascent = 0; > it->max_descent = 0; > > the problem disappears. Of course, it does: you've just made Emacs ignore characters which have non-zero ascent and descent. > Of course, it causes a problem in places where ascent and descent > are actually used, like for displaying images. More importantly, it will display characters with ascent or descent incorrectly clipped. > I just need to figure out how it->max_ascent gets computed from > glyph->descent. Like this: it->max_ascent = max (it->max_ascent, it->ascent); it->max_descent = max (it->max_descent, it->descent); IOW, it's the max value of ascent and descent of all the characters on that screen line.