From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f1baa15: Fix display when a font claims large values of ascent and descent Date: Mon, 08 Jun 2015 21:17:38 +0300 Message-ID: <83mw0akqt9.fsf@gnu.org> References: <20150606131216.11369.14106@vcs.savannah.gnu.org> <4bh9qiw0vr.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1433787515 29438 80.91.229.3 (8 Jun 2015 18:18:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Jun 2015 18:18:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 08 20:18:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z21cr-00052r-RH for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 20:18:21 +0200 Original-Received: from localhost ([::1]:59621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z21cr-0002QY-9W for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 14:18:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z21cZ-0002O5-N8 for emacs-devel@gnu.org; Mon, 08 Jun 2015 14:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z21cR-0002kO-Nq for emacs-devel@gnu.org; Mon, 08 Jun 2015 14:18:03 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:51035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z21cR-0002jh-Gc; Mon, 08 Jun 2015 14:17:55 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NPN00A0017Z1800@a-mtaout22.012.net.il>; Mon, 08 Jun 2015 21:17:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPN0090T1HSWS60@a-mtaout22.012.net.il>; Mon, 08 Jun 2015 21:17:53 +0300 (IDT) In-reply-to: <4bh9qiw0vr.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187108 Archived-At: > From: Glenn Morris > Cc: Eli Zaretskii > Date: Mon, 08 Jun 2015 13:44:40 -0400 > > > + /* Make sure this space glyph has the right ascent and > > + descent values, or else cursor at end of line will look > > + funny. */ > > + g = it->glyph_row->glyphs[TEXT_AREA] + n; > > + struct font *font = face->font ? face->font : FRAME_FONT (it->f); > > + if (n == 0 || it->glyph_row->height < font->pixel_size) > > + { > > + normal_char_ascent_descent (font, -1, &it->ascent, &it->descent); > > + it->max_ascent = it->ascent; > > + it->max_descent = it->descent; > > + /* Make sure compute_line_metrics recomputes the row height. */ > > + it->glyph_row->height = 0; > > + } > > + > > + g->ascent = it->max_ascent; > > + g->descent = it->max_descent; > > + > > This bit causes a warning in without-x builds, eg > http://hydra.nixos.org/build/23007744/log/raw > > xdisp.c:19210:8: warning: implicit declaration of function > 'normal_char_ascent_descent' [-Wimplicit-function-declaration] > normal_char_ascent_descent (font, -1, &it->ascent, &it->descent); (And will fail during linking if you build with -O0, I presume.) Thanks, I think I fixed that in 55200b4.