From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: Collation tests in fns-tests.el
Date: Fri, 30 Oct 2015 22:28:09 +0200 [thread overview]
Message-ID: <83mvv0yucm.fsf@gnu.org> (raw)
In-Reply-To: <5633AE31.2030501@cornell.edu>
> From: Ken Brown <kbrown@cornell.edu>
> Date: Fri, 30 Oct 2015 13:51:45 -0400
> Cc: Emacs <emacs-devel@gnu.org>
>
> I'm curious why you put the following test in fns-tests.el:
>
> ;; Punctuation and whitespace characters are not taken into account
> ;; for collation in other locales.
> (should
> (equal
> (sort '("11" "12" "1 1" "1 2" "1.1" "1.2")
> (lambda (a b)
> (let ((w32-collate-ignore-punctuation t))
> (string-collate-lessp
> a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8")))))
> '("11" "1 1" "1.1" "12" "1 2" "1.2")))
>
> This suggests that punctuation and whitespace should definitely not be
> taken into account in non-POSIX locales.
They were found to be ignored in all the cases we tested until now.
> But the docstring of 'sort' is much less definitive:
>
> "This function obeys the conventions for collation order in your locale
> settings. For example, punctuation and whitespace characters *might* be
> considered less significant for sorting." [My emphasis.]
>
> Is there some place where emacs relies on punctuation and whitespace
> being ignored?
Listing of files generally ignores them, as one example. ls-lisp.el
relies on that to emulate what 'ls' the program does on Posix hosts.
> P.S. My question is motivated by the fact that punctuation and
> whitespace are not ignored on Cygwin in non-POSIX locales, and it does
> not seem to be easy to make this happen. If you're interested in the
> gory details, start here:
>
> https://www.cygwin.com/ml/cygwin/2015-10/msg00516.html
You already said in that discussion what I'd suggest ;-)
Since Cygwin tries to be compatible to GNU/Linux (i.e. glibc), it
should indeed use some non-zero flags in its implementation of string
collation-dependent comparison. IMO, it makes no sense not to do
that, since users expect that to happen. Then the above test will
work for it, and moreover, ls-lisp.el will, too.
next prev parent reply other threads:[~2015-10-30 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 17:51 Collation tests in fns-tests.el Ken Brown
2015-10-30 20:28 ` Eli Zaretskii [this message]
2015-10-30 20:40 ` Eli Zaretskii
2015-10-30 21:10 ` Ken Brown
2015-10-30 21:35 ` Eli Zaretskii
2015-10-30 22:16 ` Ken Brown
2015-10-31 8:49 ` Michael Albinus
2015-10-31 9:07 ` Eli Zaretskii
2015-11-02 16:25 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvv0yucm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.