all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Module tests
Date: Sun, 06 Dec 2015 19:53:56 +0200	[thread overview]
Message-ID: <83mvtnea4r.fsf@gnu.org> (raw)

Commit 2b3f5de2b3 removed these 2 tests:

  (should (= (mod-test-sum 1 #x1fffffff)
             (1+  #x1fffffff)))
  (should (= (mod-test-sum -1 #x20000000)
             #x1fffffff))

They were written to test the code in emacs-module.c which switches
from scalar values to cons cells when the integer value is too large
for 32 bits and Emacs is compiled with wide ints.

I don't understand why the removal.  AFAICS, we still switch from
integers to cons cells, so the borderline values just above and below
the threshold are where be dragons, and we should keep them (they
helped me to find and fix a couple of bugs in the previous
implementation).  What am I missing?



             reply	other threads:[~2015-12-06 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 17:53 Eli Zaretskii [this message]
2015-12-06 22:56 ` Module tests Paul Eggert
2015-12-07  3:38   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mvtnea4r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.