all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags
Date: Fri, 05 Feb 2016 11:14:04 +0200	[thread overview]
Message-ID: <83mvrfv7s3.fsf@gnu.org> (raw)
In-Reply-To: <56B4329D.7010101@yandex.ru> (message from Dmitry Gutov on Fri, 5 Feb 2016 08:26:53 +0300)

> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 5 Feb 2016 08:26:53 +0300
> 
> Would
> 
>      alias_method :qux, :tee, :bogus
> 
> trigger the same problem, and use the same fix?

No.  What comes after the comma must begin with attr_SOMETHING or
alias_method.  The issue being tested here is that we are not in a
state where matches for these are being tried.

But if you ever figure out how to do that with a less abnormal syntax,
feel free to update the test files.

It could also be a good idea to add a Rakefile or a Thorfile to the
ruby-src directory (when I tested the change, I just renamed one of
the other files).  It could be that those present special challenges,
and in any case we should test the file-name rules.

> If not, please disregard this email. The code works well, and supports 
> all the main use cases.

OK, thanks.  I guess we now have the "best etags in the West" (and in
the East as well), as far as Ruby support is concerned.



  parent reply	other threads:[~2016-02-05  9:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160203162536.2954.45438@vcs.savannah.gnu.org>
     [not found] ` <E1aR0FM-0000mG-Up@vcs.savannah.gnu.org>
2016-02-03 23:46   ` [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Dmitry Gutov
2016-02-04  3:48     ` Eli Zaretskii
2016-02-04  9:36       ` Dmitry Gutov
2016-02-04 17:28         ` Eli Zaretskii
2016-02-05  5:26           ` Dmitry Gutov
2016-02-05  5:29             ` Dmitry Gutov
2016-02-05  9:14             ` Eli Zaretskii [this message]
2016-02-05 10:11               ` Dmitry Gutov
2016-02-05 11:15                 ` Eli Zaretskii
2016-02-05 11:26                   ` Eli Zaretskii
2016-02-05 12:15                   ` Dmitry Gutov
2016-02-05 14:34                     ` Eli Zaretskii
2016-02-06  9:09                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mvrfv7s3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.