From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Asynchronous DNS Date: Mon, 15 Feb 2016 05:41:23 +0200 Message-ID: <83mvr2y718.fsf@gnu.org> References: <877fihjo4m.fsf@gnus.org> <86io20n3xn.fsf@realize.ch> <8760y055l1.fsf@gnus.org> <8660xzmyyr.fsf@realize.ch> <87pow7ocyw.fsf@gnus.org> <861t8nmxlj.fsf@realize.ch> <87y4auiurw.fsf@gnus.org> <86k2me8dee.fsf@realize.ch> <83a8n9ddk5.fsf@gnu.org> <864mdh8vj5.fsf@realize.ch> <87pow579kt.fsf@gnus.org> <86ziv87st0.fsf@realize.ch> <87vb5u4qtq.fsf@gnus.org> <86egci6xvk.fsf@realize.ch> <87twldgsrv.fsf@gnus.org> <8637sw7w4m.fsf@realize.ch> <87vb5sdod6.fsf@gnus.org> <83lh6nzvfp.fsf@gnu.org> <87fuwv6ai4.fsf@gnus.org> <83h9hbz20t.fsf@gnu.org> <86k2m66d8k.fsf@realize.ch> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1455507725 30719 80.91.229.3 (15 Feb 2016 03:42:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Feb 2016 03:42:05 +0000 (UTC) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Alain Schneble Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 15 04:42:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aVA2y-0003Ao-HW for ged-emacs-devel@m.gmane.org; Mon, 15 Feb 2016 04:42:00 +0100 Original-Received: from localhost ([::1]:55926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVA2x-0005nI-Kk for ged-emacs-devel@m.gmane.org; Sun, 14 Feb 2016 22:41:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVA2N-0005NN-7I for emacs-devel@gnu.org; Sun, 14 Feb 2016 22:41:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVA2I-0005lS-8c for emacs-devel@gnu.org; Sun, 14 Feb 2016 22:41:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVA2I-0005lH-5J; Sun, 14 Feb 2016 22:41:18 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4089 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aVA2H-0004hc-Ct; Sun, 14 Feb 2016 22:41:17 -0500 In-reply-to: <86k2m66d8k.fsf@realize.ch> (message from Alain Schneble on Mon, 15 Feb 2016 01:14:51 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199949 Archived-At: > From: Alain Schneble > CC: Lars Ingebrigtsen , > Date: Mon, 15 Feb 2016 01:14:51 +0100 > > Eli Zaretskii writes: > > >> From: Lars Ingebrigtsen > >> Cc: a.s@realize.ch, emacs-devel@gnu.org > >> Date: Sun, 14 Feb 2016 18:01:39 +1100 > >> > >> The issue is losing asynchronicity. A function that previously called > >> > >> (progn > >> (make-network-stream ... :nowait t) > >> (set-process-coding-system ...)) > >> > >> would not block. With the proposed blockers (unless we add fine-grained > >> code to all the process function to only block if we haven't even done > >> DNS yet), this code will block. And that's a regression. > > > > If set-process-coding-system worked in the above snippet, it means it > > doesn't need to block waiting for a fully capable process object. If > > it didn't work (as in signaled an error), then there's no regression. > > set-process-coding-system, how it is currently implemented on master, > requires valid infd/outfd, hence an initialized socket. > make-network-process until now did initialize a socket also with :nowait > t. That is no longer the case in the feature/async-dns branch with the > :nowait 'dns option, where make-network-stream returns without having > initialized a socket. Yes, I know. So there's no regression, since the above snippet doesn't work on the async-dns branch because set-process-coding-system signals an error.