From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Tue, 08 Mar 2016 17:57:41 +0200 Message-ID: <83mvq9rmh6.fsf@gnu.org> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <834mchtz8q.fsf@gnu.org> <878u1ta97x.fsf@wanadoo.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1457452661 16393 80.91.229.3 (8 Mar 2016 15:57:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 15:57:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?=D3scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 16:57:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adK0x-0007z0-Ei for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 16:57:39 +0100 Original-Received: from localhost ([::1]:35491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adK0x-0001pJ-2T for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 10:57:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adK0u-0001pE-Jb for emacs-devel@gnu.org; Tue, 08 Mar 2016 10:57:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adK0r-0007Bh-71 for emacs-devel@gnu.org; Tue, 08 Mar 2016 10:57:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adK0r-0007Bd-4S; Tue, 08 Mar 2016 10:57:33 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2701 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1adK0q-0006S5-FS; Tue, 08 Mar 2016 10:57:32 -0500 In-reply-to: <878u1ta97x.fsf@wanadoo.es> (message from =?iso-8859-1?Q?=D3s?= =?iso-8859-1?Q?car?= Fuentes on Tue, 08 Mar 2016 05:23:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201156 Archived-At: > From: Óscar Fuentes > Date: Tue, 08 Mar 2016 05:23:46 +0100 > > >> Introduce code reviews. Don't give commit access to the "golden" > >> branches to everyone, just to a few top contributors and reviewers. > > > > We don't have manpower for that. > > I find perplexing that we have manpower for reviewing ChangeLogs but not > for reviewing commit logs *instead*. I'm surprised that you find it perplexing. Log messages are much shorter than code diffs, and much simpler to read and understand. It takes a few seconds to read them; reading a code patch takes much more, typically needs to consult the surrounding and related code, etc. So code review takes orders of magnitude more time than reviewing the corresponding log entries. > And is it so super-important to have typo-free commit logs? Typos is the least of our problems. But yes, it's important: if you start by forgiving typos, you end with unhelpful and uninformative log messages. > We are not even using `git notes'. No one came up with a detailed procedure for doing that. If you can propose something that works, please do.