From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23076: 24.5; vc-git: add a new variable for log output coding system Date: Fri, 08 Apr 2016 11:23:43 +0300 Message-ID: <83mvp4jypc.fsf@gnu.org> References: <56EFE033.7080900@gmail.com> <56F04527.6010901@gmail.com> <83fuv4s4cr.fsf@gnu.org> <57017E45.7050605@gmail.com> <83pou5o0uh.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460103919 21949 80.91.229.3 (8 Apr 2016 08:25:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Apr 2016 08:25:19 +0000 (UTC) Cc: 23076@debbugs.gnu.org To: nikolay.kudryavtsev@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 08 10:25:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aoRj7-000168-AR for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Apr 2016 10:25:13 +0200 Original-Received: from localhost ([::1]:54919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRj6-0005v8-EZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Apr 2016 04:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRj1-0005pg-SF for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2016 04:25:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoRiv-0003fB-VM for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2016 04:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRiv-0003f7-RP for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2016 04:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aoRiv-00024v-Mr for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2016 04:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Apr 2016 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23076-submit@debbugs.gnu.org id=B23076.14601038527930 (code B ref 23076); Fri, 08 Apr 2016 08:25:01 +0000 Original-Received: (at 23076) by debbugs.gnu.org; 8 Apr 2016 08:24:12 +0000 Original-Received: from localhost ([127.0.0.1]:53480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoRi7-00023q-Vw for submit@debbugs.gnu.org; Fri, 08 Apr 2016 04:24:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoRi5-00023c-Ra for 23076@debbugs.gnu.org; Fri, 08 Apr 2016 04:24:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoRhv-0003Sa-S6 for 23076@debbugs.gnu.org; Fri, 08 Apr 2016 04:24:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRhv-0003SW-Om; Fri, 08 Apr 2016 04:23:59 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aoRhv-0001ju-05; Fri, 08 Apr 2016 04:23:59 -0400 In-reply-to: <83pou5o0uh.fsf@gnu.org> (message from Eli Zaretskii on Mon, 04 Apr 2016 18:22:30 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116192 Archived-At: > Date: Mon, 04 Apr 2016 18:22:30 +0300 > From: Eli Zaretskii > Cc: 23076@debbugs.gnu.org > > So instead, I can suggest one of the following alternatives, to be > done only when invoking Git to commit on MS-Windows: > > 1) ignore vc-git-commits-coding-system and always encode the > command-line arguments using the system locale (in your case, > codepage 1251); or > > 2) put the log message in a temporary file, encoded in > vc-git-commits-coding-system, then use -F instead of -m; the rest > of command-line arguments will be encoded in the system locale's > codepage > > The 1st solution is essentially what you wanted, but without the need > to introduce an additional variable or ask the users to configure it. > > The 2nd solution is somewhat slower, but it is better, because it will > allow to write log messages using any characters, not just those > representable in the current codepage. Note that it still doesn't > solve all the problems with non-ASCII characters, because those could > be in the "author" or any of the other arguments with which we call > Git, such as the names of the files whose changes are to be committed > (as Emacs does support arbitrary characters in file names). > > Comments? Ping!