From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f995fbd: * lisp/server.el (server-name): Add autoload cookie. (Bug#23576) Date: Fri, 20 May 2016 10:46:05 +0300 Message-ID: <83mvnl894y.fsf@gnu.org> References: <20160518194708.27363.47377@vcs.savannah.gnu.org> <20160518194708.86FE0220157@vcs.savannah.gnu.org> <834m9u9dis.fsf@gnu.org> <83r3cx8eg2.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1463730386 27696 80.91.229.3 (20 May 2016 07:46:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 May 2016 07:46:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 20 09:46:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b3f8O-0000vI-J9 for ged-emacs-devel@m.gmane.org; Fri, 20 May 2016 09:46:12 +0200 Original-Received: from localhost ([::1]:53568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3f8N-00052m-R6 for ged-emacs-devel@m.gmane.org; Fri, 20 May 2016 03:46:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3f8E-00051D-L4 for emacs-devel@gnu.org; Fri, 20 May 2016 03:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3f8A-0001h8-9c for emacs-devel@gnu.org; Fri, 20 May 2016 03:46:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3f8A-0001g5-6V; Fri, 20 May 2016 03:45:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2866 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b3f88-0001o7-8h; Fri, 20 May 2016 03:45:56 -0400 In-reply-to: (message from Leo Liu on Fri, 20 May 2016 15:11:45 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203899 Archived-At: > From: Leo Liu > Date: Fri, 20 May 2016 15:11:45 +0800 > > On 2016-05-20 08:51 +0300, Eli Zaretskii wrote: > > Sorry, I don't think I understand what that means. What duplication > > do you allude to here? > > For example if you autoload server-name, the whole > > (defcustom server-name "server" > "The name of the Emacs server, if this Emacs process creates one. > The command `server-start' makes use of this. It should not be > changed while a server is running." > :group 'server > :type 'string > :version "23.1") > > is duplicated to the loaddefs file and now you have two definitions in > two separate files. And why is that a problem? loaddefs.el is auto-generated, so no one needs to maintain it. > > I added the autoload for a reason for which I didn't see a better > > solution. If you can suggest a better solution that allows users to > > specify the name before starting the first server, please do. > > Get rid of the set-variable. Sorry, no. I use that command myself a lot, so I see no reason why it should be avoided.