From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) Date: Sat, 13 Aug 2016 21:31:22 +0300 Message-ID: <83mvkgcyh1.fsf@gnu.org> References: <20160810044910.10174.12870@vcs.savannah.gnu.org> <20160810044911.2B1C52201C2@vcs.savannah.gnu.org> <20160811013050.GA4775@holos.localdomain> <20160813181832.GA15753@holos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471113128 22769 195.159.176.226 (13 Aug 2016 18:32:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Aug 2016 18:32:08 +0000 (UTC) Cc: jwiegley@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 13 20:32:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYdj1-0005jt-Og for ged-emacs-devel@m.gmane.org; Sat, 13 Aug 2016 20:32:03 +0200 Original-Received: from localhost ([::1]:58240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYdiy-0001v9-Rc for ged-emacs-devel@m.gmane.org; Sat, 13 Aug 2016 14:32:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYdis-0001ur-4c for emacs-devel@gnu.org; Sat, 13 Aug 2016 14:31:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYdiq-0004yO-4x for emacs-devel@gnu.org; Sat, 13 Aug 2016 14:31:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYdil-0004yA-3i; Sat, 13 Aug 2016 14:31:47 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1857 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bYdih-0005dY-3F; Sat, 13 Aug 2016 14:31:45 -0400 In-reply-to: <20160813181832.GA15753@holos.localdomain> (message from Mark Oteiza on Sat, 13 Aug 2016 14:18:32 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206596 Archived-At: > Date: Sat, 13 Aug 2016 14:18:32 -0400 > From: Mark Oteiza > Cc: emacs-devel@gnu.org, John Wiegley , > Eli Zaretskii > > On 10/08/16 at 10:36pm, Stefan Monnier wrote: > > > Seems like a lot of low hanging fruit to pick and I should post > > > a patch, WDYT? > > > > Go for it. > > Done. Flipped the switch and fixed small warnings on files in > lisp/*.el, but didn't bother with fixing other kinds of warnings or > altering libs actually using dynamic binding or didn't already have > a compile-time dependency on cl{,-lib} for {,cl-}pushnew. Nothing > appears to be broken, but AFAIK I don't make regular use of many of > these libraries. IMO, we should have tests for each one of them before we do this. Thanks.