From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24326: 25.1; Daemon doesn't exit on Windows if kill-emacs-hook asks a question Date: Mon, 29 Aug 2016 17:38:11 +0300 Message-ID: <83mvjvbpyk.fsf@gnu.org> References: <83shtobthc.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472481606 32447 195.159.176.226 (29 Aug 2016 14:40:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2016 14:40:06 +0000 (UTC) To: 24326@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 29 16:39:58 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beNj7-0007EO-35 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Aug 2016 16:39:53 +0200 Original-Received: from localhost ([::1]:43896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNj4-00019L-Mr for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Aug 2016 10:39:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNiN-0000pD-T2 for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2016 10:39:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beNiI-0007LW-Uz for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2016 10:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNiI-0007LR-Jo for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2016 10:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1beNiI-0007wk-CK for bug-gnu-emacs@gnu.org; Mon, 29 Aug 2016 10:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Aug 2016 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24326-submit@debbugs.gnu.org id=B24326.147248150430497 (code B ref 24326); Mon, 29 Aug 2016 14:39:02 +0000 Original-Received: (at 24326) by debbugs.gnu.org; 29 Aug 2016 14:38:24 +0000 Original-Received: from localhost ([127.0.0.1]:43705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beNhg-0007vp-Fx for submit@debbugs.gnu.org; Mon, 29 Aug 2016 10:38:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beNhe-0007vb-Ix for 24326@debbugs.gnu.org; Mon, 29 Aug 2016 10:38:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beNhV-00074W-CU for 24326@debbugs.gnu.org; Mon, 29 Aug 2016 10:38:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNhV-00074R-7e for 24326@debbugs.gnu.org; Mon, 29 Aug 2016 10:38:13 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4289 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1beNhT-0003P0-By for 24326@debbugs.gnu.org; Mon, 29 Aug 2016 10:38:11 -0400 In-reply-to: <83shtobthc.fsf@gnu.org> (message from Eli Zaretskii on Sun, 28 Aug 2016 22:09:51 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122755 Archived-At: > Date: Sun, 28 Aug 2016 22:09:51 +0300 > From: Eli Zaretskii > > Not sure how to solve this. One possibility would be to disable the > "Save desktop?" question in this case, on MS-Windows only, and instead > act as if the answer is NO. desktop-kill is called from several > places, so if we go this way, we will have to devise a way of figuring > out that the question cannot be answered. Actually, here's a simple solution: diff --git a/lisp/server.el b/lisp/server.el index 5300984..d34546d 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -648,7 +648,7 @@ server-start (add-hook 'delete-frame-functions 'server-handle-delete-frame) (add-hook 'kill-emacs-query-functions 'server-kill-emacs-query-function) - (add-hook 'kill-emacs-hook 'server-force-stop) ;Cleanup upon exit. + (add-hook 'kill-emacs-hook 'server-force-stop t) ;Cleanup upon exit. (setq server-process (apply #'make-network-process :name server-name I wonder if it ever makes sense for server.el to have its kill-emacs-hook before any others. server-force-stop deletes all the client frames, so if there are no other frames, our capabilities to communicate with the user are thereafter seriously degraded. If the above is deemed too bold, we could do that only in the daemon, using daemonp for the test. Comments?