From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Thu, 08 Sep 2016 20:23:24 +0300 Message-ID: <83mvji8fw3.fsf@gnu.org> References: <20160907153014.15752-1-toke@toke.dk> <83vay785v6.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1473362174 2923 195.159.176.226 (8 Sep 2016 19:16:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2016 19:16:14 +0000 (UTC) Cc: toke@toke.dk, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 21:16:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi4nu-0007g1-4X for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 21:16:06 +0200 Original-Received: from localhost ([::1]:52938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi4no-0003HC-L8 for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 15:16:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi33I-0006Mc-WF for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:23:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi33E-0003rn-FC for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:23:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi33E-0003rh-Bs; Thu, 08 Sep 2016 13:23:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3276 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bi33D-0006gL-0K; Thu, 08 Sep 2016 13:23:47 -0400 In-reply-to: (message from Lars Ingebrigtsen on Thu, 08 Sep 2016 11:07:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207297 Archived-At: > From: Lars Ingebrigtsen > Cc: toke@toke.dk, emacs-devel@gnu.org > Date: Thu, 08 Sep 2016 11:07:17 +0200 > > Eli Zaretskii writes: > > > That makes very little sense to me, as it will re-introduce the > > problems which caused us to add the test. And it's a code change, so > > it will require at least the same amount of testing that whatever fix > > we come up with for this use case. Sounds like lose-lose to me. > > The problems were pretty obscure, since most servers don't care much > about what the length header says. And removing the error-out has a > very small chance of breaking anything, to put it mildly. It sounds like you don't consider this issue serious enough to be solved, in Emacs 25.1 or at all. If so, I certainly disagree, and we already decided we want to fix this. So undoing that decision now would be a step backwards for no good reason. > And we have no idea how many of these unencoded parameters remain to be > encoded (because of the rather wonky url calling conventions), so we > could be adding these encoding patches piecemeal to Emacs 25.1 pretests > for the next couple of years (at the current going rate of one per > month) while waiting to find them all. If we think other parts of the request can produce similar problems, we can encode them all now. At the time, the consensus was that this couldn't happen, but if we made a mistake, it can be easily and safely fixed.