From: Eli Zaretskii <eliz@gnu.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 24456@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords
Date: Wed, 21 Sep 2016 17:56:51 +0300 [thread overview]
Message-ID: <83mvj1fgi4.fsf@gnu.org> (raw)
In-Reply-To: <87d1jz7hx3.fsf@secretsauce.net> (message from Dima Kogan on Mon, 19 Sep 2016 13:28:56 -0700)
> From: Dima Kogan <dima@secretsauce.net>
> Cc: npostavs@users.sourceforge.net, 24456@debbugs.gnu.org
> Date: Mon, 19 Sep 2016 13:28:56 -0700
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > What exactly requires testing for ASCII lower-case letters in your
> > patch? Why only ASCII?
>
> I'm trying to detect the caps-lock by finding capital letters that were
> produced without Shift (and vice versa). I can do something like
>
> !shift_pressed && isupper(c)
>
> but that doesn't work with wide characters. There's iswupper(c). Are the
> wide chars it takes the same ones we get in that function? How about
> non-latin scripts?
We already have an inline function 'uppercasep', which you could use;
it supports any character that Emacs supports.
> Fundamentally I'm the worst person to be testing this, sadly.
Once the code is written, we can ask people to test it in different
locales, I don't expect problems in this area.
Thanks.
next prev parent reply other threads:[~2016-09-21 14:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 7:01 bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords Dima Kogan
2016-09-18 14:04 ` npostavs
2016-09-18 18:25 ` Dima Kogan
2016-09-18 18:54 ` npostavs
2016-09-19 2:23 ` Eli Zaretskii
2016-09-19 5:22 ` Dima Kogan
2016-09-19 16:43 ` Eli Zaretskii
2016-09-19 18:15 ` Dima Kogan
2016-09-19 18:50 ` Eli Zaretskii
2016-09-19 20:28 ` Dima Kogan
2016-09-21 14:56 ` Eli Zaretskii [this message]
2016-09-21 23:30 ` Dima Kogan
2016-09-22 15:22 ` Eli Zaretskii
2016-09-25 18:44 ` Dima Kogan
2016-10-01 8:28 ` Eli Zaretskii
2016-10-01 15:12 ` Dima Kogan
2016-10-01 15:59 ` Eli Zaretskii
2016-10-15 14:23 ` Eli Zaretskii
2016-10-01 8:37 ` Andreas Schwab
2016-09-18 14:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvj1fgi4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24456@debbugs.gnu.org \
--cc=dima@secretsauce.net \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.